workflows: scan all shell scripts #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basak-qcom
force-pushed
the
full-shellcheck
branch
4 times, most recently
from
d66b545 to
afad673
Compare
lool
approved these changes
Jun 24, 2025
Contributor
lool
left a comment
lool
left a comment
There was a problem hiding this comment.
Looks good; left a few proposed improvements, but happy to merge
Instead of just scripts/*.sh, scan all scripts found in the repository using `file`. I didn't find a widely accepted mechanism to do this so settled on using `file`. The script is at least not too long to follow, doesn't introduce any external dependency, and is careful to avoid errors from unusual characters in filenames (eg. backslash escapes and carriage returns) to try and be safe against all inputs. If this pattern works, we could extend it to the other lint checks in this file. Signed-off-by: Robie Basak <[email protected]>
basak-qcom
force-pushed
the
full-shellcheck
branch
from
afad673 to
b1781ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just scripts/*.sh, scan all scripts found in the repository using
file.I didn't find a widely accepted mechanism to do this so settled on using
file. The script is at least not too long to follow, doesn't introduce any external dependency, and is careful to avoid errors from unusual characters in filenames (eg. backslash escapes and carriage returns) to try and be safe against all inputs.If this pattern works, we could extend it to the other lint checks in this file.