Add qcom-fitimage.its as a reference FIT ITS file #4
Conversation
qcom-fitimage.its
Outdated
| type = "flat_dt"; | ||
| }; | ||
| fdt-qcm6490-video.dtbo { | ||
| data = /incbin/("./qcm6490-video.dtbo"); |
There was a problem hiding this comment.
Can we add a comment here that the path for the dtbo must same as the relative location where dtbo are present wrt the fit image?
There was a problem hiding this comment.
Let's keep qcom-next and upstream as reference where qcm6490-video.dtbo does not exist.
qcom-fitimage.its
Outdated
| configurations { | ||
| conf-1 { | ||
| compatible = "qcom,qcm6490-idp"; | ||
| fdt = "fdt-qcm6490-idp.dtb", "fdt-qcm6490-video.dtbo", "fdt-qcm6490-graphics.dtbo", "fdt-qcm6490-camera-idp.dtbo"; |
There was a problem hiding this comment.
The overlays should not be enabled by default. Please add an entry with the extra variant appended.
There was a problem hiding this comment.
Okay, as long as static overlays are not needed by any other team, overlays need not be mentioned here by default.
e.g. if any team like camera need overlay, they can use the efi vars approach for dynamic overlays.
I have discussed above with @sbanerjee-quic and we are in agreement as well.
There was a problem hiding this comment.
@quic-kaushalk will you update/revise this patch and remove all overlay entries ?
qcom-fitimage.its
Outdated
| type = "flat_dt"; | ||
| }; | ||
| fdt-qcm6490-video.dtbo { | ||
| data = /incbin/("./qcm6490-video.dtbo"); |
There was a problem hiding this comment.
Let's keep qcom-next and upstream as reference where qcm6490-video.dtbo does not exist.
qcom-fitimage.its
Outdated
| type = "flat_dt"; | ||
| }; | ||
| fdt-qcm6490-graphics.dtbo { | ||
| data = /incbin/("./qcm6490-graphics.dtbo"); |
There was a problem hiding this comment.
same for graphics and other subsystem (following) dtbos.
We will add them incrementally, when the overlay feature is added and based on which subsystem needs a boot time overlay.
qcom-fitimage.its
Outdated
| type = "flat_dt"; | ||
| }; | ||
| fdt-qcs9075-iq-9075-evk.dtb { | ||
| data = /incbin/("./arch/arm64/boot/dts/qcom/qcs9075-iq-9075-evk.dtb"); |
There was a problem hiding this comment.
upstream name for rb8 dtb is lemans-evk.dtb
There was a problem hiding this comment.
yes, this version of file used the merged filenames in 1.0 only for validating build. Shall be getting updated in next patch.
qcom-fitimage.its
Outdated
| type = "flat_dt"; | ||
| }; | ||
| fdt-qcs8275-iq-8275-evk.dtb { | ||
| data = /incbin/("./arch/arm64/boot/dts/qcom/qcs8275-iq-8275-evk.dtb"); |
There was a problem hiding this comment.
and upstream name for rb4 dtb is monaco-evk.dtb
There was a problem hiding this comment.
yes, this version of file used the merged filenames in 1.0 only for validating build. Shall be getting updated in next patch.
qcom-fitimage.its
Outdated
| configurations { | ||
| conf-1 { | ||
| compatible = "qcom,qcm6490-idp"; | ||
| fdt = "fdt-qcm6490-idp.dtb", "fdt-qcm6490-video.dtbo", "fdt-qcm6490-graphics.dtbo", "fdt-qcm6490-camera-idp.dtbo"; |
There was a problem hiding this comment.
@quic-kaushalk will you update/revise this patch and remove all overlay entries ?
| fdt = "fdt-qcs9075-iq-9075-evk.dtb", "fdt-sa8775p-video.dtbo", "fdt-qcs9100-graphics.dtbo", "fdt-qcs9075-camera-iq-9075-evk.dtbo"; | ||
| }; | ||
| conf-6 { | ||
| compatible = "qcom,qcs9100-adp"; |
There was a problem hiding this comment.
I think it is s/adp/qam , please check (correspnding to ridesx).
| fdt = "fdt-qcs9100-ride.dtb", "fdt-sa8775p-video.dtbo", "fdt-qcs9100-graphics.dtbo", "fdt-qcs9100-ride-sx-camera.dtbo"; | ||
| }; | ||
| conf-7 { | ||
| compatible = "qcom,qcs8300-adp"; |
There was a problem hiding this comment.
No, ride is adp. ridesx is qam.
qcom-fitimage.its
Outdated
| }; | ||
| conf-8 { | ||
| compatible = "qcom,qcs8275-iot"; | ||
| fdt = "fdt-qcs8275-iq-8275-evk.dtb", "fdt-qcs8300-video.dtbo", "fdt-qcs8300-graphics.dtbo", "fdt-qcs8275-camera-iq-8275-evk.dtbo"; |
There was a problem hiding this comment.
fix the rb4 dtb name aligned to upstream.
qcom-fitimage.its
Outdated
| }; | ||
| conf-5 { | ||
| compatible = "qcom,qcs9075-iot"; | ||
| fdt = "fdt-qcs9075-iq-9075-evk.dtb", "fdt-sa8775p-video.dtbo", "fdt-qcs9100-graphics.dtbo", "fdt-qcs9075-camera-iq-9075-evk.dtbo"; |
There was a problem hiding this comment.
fix the rb8 dtb name aligned to upstream.
4 participants
Add qcom-fitimage.its as a reference. In cases where ITS is not being generated, this file can used as well.