-
Notifications
You must be signed in to change notification settings - Fork 21
Added Support for Display IGT Tests #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: manasab-qli <[email protected]>
@@ -0,0 +1,68 @@ | |||
# Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. | |||
# SPDX-License-Identifier: BSD-3-Clause-Clear |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove # from CR
2. Run the script: | ||
|
||
```bash | ||
./run.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add even the steps to run the core_auth test from run-test.sh
# Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. | ||
# SPDX-License-Identifier: BSD-3-Clause-Clear | ||
|
||
# Import test suite definitions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the standard procedure to source init_env and functestlib.sh. For more information, refer to the guidelines.
echo "Checking if dependency binary is available" | ||
|
||
# Set the library path for the IGT tests | ||
if [ -d "/data/" ] && [ -d "/data/igt/lib" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data folder won't be available on mainline builds.
fi | ||
|
||
# Navigate to the directory containing the IGT tests | ||
cd /data/igt/tests/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this, better launch the core_auth from the relative path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes need to be made as suggested in the review comments.
cd /data/igt/tests/ | ||
|
||
# Run the core_auth test and log the output to a file | ||
./core_auth 2>&1 | tee /data/core_auth_log.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check if core_auth is available first?
Please add commit message describing what is done in this commit |
This pull request has been marked as stale due to 30 days of inactivity. To prevent automatic closure in 7 days, remove the stale label or add a comment. You can reopen a closed pull request at any time. |
Added Support Display IGT Tests