Fix ShellCheck workflow to correctly scope PR and main branch analysis #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hellCheck fixes from UFS/eMMC run.sh scripts This change improves the scan_dmesg_errors() function to: - Filter dmesg errors based on a scoped keyword (e.g., 'ufs', 'mmc', 'bt') - Reduce false positives by narrowing context to relevant lines - Log both raw snapshot and filtered messages for traceability Also addressed ShellCheck warnings across the UFS/eMMC run.sh scripts: - SC2012: Replaced ls with find for safer handling of filenames - SC2034: Removed or justified unused variable assignments Signed-off-by: Srikanth Muppandam <[email protected]>
- Updated to properly differentiate between PRs and direct pushes to - On pull_request: only runs ShellCheck on changed files to avoid false positives from main - On push to main and manual dispatch: runs ShellCheck on all files in the repository - Ensures accurate and relevant linting results on both CI and developer PRs - Fixes issue where shellcheck errors from main were incorrectly reported on unrelated PRs Signed-off-by: Srikanth Muppandam <[email protected]>
smuppand
force-pushed
the
shell-lint-workflow
branch
from
a106b7d to
272361a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an issue where the ShellCheck workflow was incorrectly reporting errors on PRs due to lint violations present on the
mainbranch.Fixes Included
.github/workflows/shell-lint.ymlto:.shfiles during pull requests..shfiles duringpushtomainor manual dispatch.mainfrom appearing in pull request checks.Benefits