Skip to content

Fix: Enforce executable permissions via workflow and restore +x on gpdsp test #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

Fix: Enforce executable permissions via workflow and restore +x on gpdsp test #134

merged 1 commit into from
Jul 28, 2025

Conversation

smuppand
Copy link
Contributor

This PR includes the following changes:

  1. Workflow Fix for Permission Enforcement
  • Replaces pull_request_target with pull_request to correctly inspect PR changes before merge.
  • Adds paths filters to limit execution to changes in .sh and run.sh files.
  • Improves script output with clear error annotations and per-file messages.
  • Adds an optional check to warn about non-shell files with executable bits.
  • Adds a job name to improve visibility in GitHub Actions UI.
  1. Fix Executable Permission on gpdsp Test
  • Restores +x permission on the gpdsp test script to ensure it runs as expected in CI and LAVA environments.

@smuppand
ci: fix permission check workflow and restore +x for gpdsp test
dd2fb3f 
- Fixed GitHub Actions workflow to run permission checks on actual PR code using `pull_request` instead of `pull_request_target`
- Added `paths` filters to trigger only on relevant `.sh` files
- Improved error and warning output with GitHub annotations for missing +x
- Added optional check for non-shell files with executable bit
- Named the job for clarity in UI

Also:
- Restored executable permissions (+x) on gpdsp test script to ensure it runs correctly in CI and LAVA

Signed-off-by: Srikanth Muppandam <[email protected]>
@smuppand smuppand requested a review from vnarapar July 28, 2025 05:32
vnarapar
vnarapar approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@vnarapar vnarapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vnarapar
Copy link
Contributor

ignoring the permission checker as it is known issue

@vnarapar vnarapar merged commit 00126f1 into qualcomm-linux:main Jul 28, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vnarapar vnarapar vnarapar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smuppand @vnarapar