Fix: ensure wpss_remoteproc.res file is always generated #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnarapar
reviewed
Jul 28, 2025
|
can you remove fail_and_exit from adsp_remoteproc and cdsp_remoteproc aswell |
- Replaced usage of `fail_and_exit` with explicit logging and .res file creation - Ensures that all failure exit paths write the expected result file (e.g., wpss_remoteproc.res) - Fixes issue where send-to-lava.sh reports missing result file due to early script exit without writing status - Also avoids silent test failures being marked incomplete by CI infrastructure Signed-off-by: Srikanth Muppandam <[email protected]>
As per your request, I have removed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced all fail_and_exit and early exit paths with proper .res file creation (PASS, FAIL, or SKIP)
Made RES_FILE path absolute to avoid issues caused by cd or relative directory changes
Added a final fallback check to ensure .res is created before exiting
Ensures LAVA and test harnesses can always rely on result presence for this test