Skip to content

Conversation

smuppand
Copy link
Contributor

@smuppand smuppand commented Aug 8, 2025

What

  • Refactored Camera_RDI_FrameCapture/run.sh to be fully modular, sourcing all pipeline detection, parsing, and block execution logic from functestlib.sh and utils/camera/parse_media_topology.py.
  • The Python parser now dynamically handles sensor renaming and pad variations, ensuring robust camera block discovery on any Qualcomm-based platform.
  • Improved error handling, logging, and result file emission for CI/CD and test automation.
  • Run.sh logic matches the proven manual media-ctl/yavta flow, ensuring pipeline works even if entity order or naming varies.

Why

  • Existing logic was failing on device/sensor changes and required manual intervention.
  • Needed a robust, sensor-agnostic solution that can adapt to topology or driver changes.
  • Modularization enables reuse, easier maintenance, and faster debugging across the camera validation suite.

How

  • All core camera pipeline steps now use reusable shell/Python helpers.
  • Output is strictly structured for automated result parsing.
  • Format override and pad handling is correct for all known camera entity topologies.

…for Robust, Sensor-agnostic Pipeline

- Refactored run.sh to use shared modular helpers from functestlib.sh.
- Added dynamic detection of camera pipeline entities via improved Python parser.
- Now supports format overrides, dynamic pad configuration, and per-device topology changes.
- Frame capture logic is resilient to sensor renaming, entity reordering, or format/pad quirks.
- Output parsing and execution flow closely match successful manual test procedure.
- Fully ShellCheck and POSIX compliant; per-step logging and clean .res file reporting.
- All core logic (media-ctl setup, yavta commands, pipeline parsing) is maintainable and future-proof.
- Fixes issue where previous scripts skipped valid pipelines or failed on device variations.

Signed-off-by: Srikanth Muppandam <[email protected]>
@smuppand smuppand requested review from abbajaj806 and vnarapar August 8, 2025 16:58
Copy link
Contributor

@abbajaj806 abbajaj806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@abbajaj806 abbajaj806 merged commit 40a2abd into qualcomm-linux:main Aug 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants