Skip to content

Conversation

smuppand
Copy link
Contributor

This PR updates Runner/suites/Multimedia/CDSP/fastrpc_test/run.sh with the following improvements:

  • Make --arch flag truly optional:
    • If provided, pass -a <arch> to fastrpc_test.
    • If omitted, skip the -a argument entirely (no default arch injected).
  • Improve debugging and CI visibility:
    • Print full binary path (/usr/bin/fastrpc_test).
    • Log file details and permissions (ls -l, file <binary>).
    • Log the exact command executed before running each iteration.
  • Preserve support for --bin-dir and --assets-dir overrides.
  • Continue writing iteration logs (iterN.out) and return codes (iterN.rc).
  • No functional change to result parsing: still detects "All tests completed successfully".

This ensures the test is more portable across platforms, avoids failures when
-a is not required, and provides better transparency in CI environments.

This update improves the fastrpc_test runner script:

- The --arch argument is now optional. If omitted, the script will not
  pass the -a flag to fastrpc_test at all.
- Removed local timeout implementation and reused the common
run_with_timeout() from functestlib.sh for consistency and
  maintainability.

Signed-off-by: Srikanth Muppandam <[email protected]>
@smuppand smuppand requested a review from abbajaj806 August 26, 2025 04:30
Copy link
Contributor

@abbajaj806 abbajaj806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@abbajaj806 abbajaj806 merged commit 918e456 into qualcomm-linux:main Aug 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants