fastrpc_test: robust binary/assets discovery (default /usr/bin/linux), buffering fallback, and guaranteed .res #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o /usr/bin/linux - Add resilient binary discovery: * prefer --bin-dir * else PATH via command -v * else fallbacks (/usr/bin/fastrpc_test, /opt/qcom/bin/fastrpc_test) - Resolve assets directory with clear priority: * --assets-dir / FASTRPC_ASSETS_DIR * (so /usr/bin → /usr/bin/linux by default) * SCRIPT_DIR * FHS-ish fallbacks (/usr/share|/usr/lib/fastrpc_test) - Prefer /linux as default to match install layout (/usr/bin/linux) - Buffering execution fallback: stdbuf → script → plain, with optional timeout - Improve logs (binary path/details, run dir, repeats, timeout, buffering) - Guarantee .res creation on all exit paths for CI/LAVA consumption Signed-off-by: Srikanth Muppandam <[email protected]>
smuppand
force-pushed
the
fastrpc-test
branch
from
b26ff4a to
05da272
Compare
quic-mtharu
approved these changes
Sep 2, 2025
ekanshibu
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fastrpc_test wrapper was flaky in CI because the binary/assets paths depended on CWD and PATH.
This PR makes path resolution deterministic, defaults assets to /usr/bin/linux (matching our package layout),
adds resilient stdout buffering fallback, and guarantees a .res file for LAVA/CI consumption.
Changes
--bin-dircommand -v fastrpc_test/usr/bin/fastrpc_test,/opt/qcom/bin/fastrpc_test-xand log binary details (ls/file)--assets-dir/FASTRPC_ASSETS_DIR$BINDIR(so/usr/bin/linuxin our layout)$SCRIPT_DIR/usr/share|/usr/lib/fastrpc_test/linuxstdbuf -oL -eL→ elsescript -q→ else plain exec--timeoutintegrated via existingrun_with_timeout--repeat,--timeout,--arch,--bin-dir,--assets-dir,--verbose<testname>.res(PASS/FAIL) on every exit path./logs_fastrpc_test_<ts>/