fastrpc_test: default to /usr/bin; add --bin-dir/--assets-dir; block /bin unless explicitly allowed #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/bin unless explicitly allowed - Always prefer /usr/bin/fastrpc_test (do not rely on PATH ordering or shell hash). - Support --bin-dir <dir> to point at a specific install prefix (runs <dir>/fastrpc_test). - Support --assets-dir <dir>; expects <dir>/linux/ (defaults to /usr/bin or $BINDIR/linux). - Only use /bin/fastrpc_test when explicitly allowed via ALLOW_BIN_FASTRPC=1 (or --bin-dir /bin). - Remove /opt probing and any overlay timing logic—image construction guarantees /usr/bin. - Invoke fastrpc_test as -d 3 -t linux (drop -U 1 user-PD flag). - Keep result/log behavior unchanged; cd into the resolved assets dir so linux/ lookups work. Signed-off-by: Srikanth Muppandam <[email protected]>
smuppand
force-pushed
the
fastrpc-test
branch
from
18e972f to
1bad903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes fastrpc_test invocation deterministic in both LAVA and manual runs by preferring the /usr/bin build, and only using /bin when explicitly allowed. It also lets callers override the binary and assets locations via flags.