Skip to content

graphics: harden kmscube & weston-simple-egl tests (robust Wayland env, deterministic .res, CI-friendly logs) #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 6, 2025
Merged

graphics: harden kmscube & weston-simple-egl tests (robust Wayland env, deterministic .res, CI-friendly logs) #161

merged 2 commits into from
Sep 6, 2025

Conversation

smuppand
Copy link
Contributor

@smuppand smuppand commented Sep 5, 2025

What changed

  • kmscube

    • Fix binary detection (check_dependencies kmscube) to avoid false SKIPs.
    • Run from testcase dir; write ./KMSCube.res next to run.sh.
    • Headless path: stop Weston if running, exercise DRM, relaunch Weston after.
    • Parse “Rendered N frames”; accept N or N-1 (lenient timing).
    • Logs to KMSCube_run.log; clearer PASS/FAIL/SKIP.

  • weston-simple-egl

    • Resolve Wayland socket from env or scan common locations (/dev/socket/weston, /run/user/*).
    • Start Weston if needed; adopt XDG_RUNTIME_DIR/WAYLAND_DISPLAY; validate with wayland-info.
    • Run for configurable duration (DURATION, default 30s) with timeout.
    • Optional FPS parsing (enable via SIMPLE_EGL_FPS=1/WESTON_SIMPLE_EGL_FPS=1); soft check by default, hard gate with REQUIRE_FPS=1 and EXPECT_FPS±FPS_TOL_PCT.
    • CI logs include rc, elapsed, and FPS (when available); write ./weston-simple-egl.res.

  • utils

    • Add print_path_meta() helper in functestlib.sh (owner/perms via stat) to aid debugging and silence ShellCheck warnings.

  • Why

    • Make results deterministic for LAVA/CI and eliminate false SKIPs/failures due to naming, path, or environment quirks.
    • Improve debuggability with explicit logs and environment adoption/validation.

  • How to use

    • kmscube: FRAME_COUNT=999 ./run.sh
    • weston-simple-egl: DURATION=30s EXPECT_FPS=60 FPS_TOL_PCT=10 REQUIRE_FPS=0 ./run.sh

@smuppand
graphics: kmscube — fix binary check, robust frame parsing, and Westo…
ef79589 
…n handling

- Use 'check_dependencies kmscube' (not 'KMSCube') to avoid false SKIPs.
- Run from the testcase dir; write ./KMSCube.res next to run.sh.
- If Weston is running, stop it; run kmscube headless on DRM; relaunch Weston.
- Parse 'Rendered N frames' and accept N or N-1 for leniency.
- Support FRAME_COUNT override; log to KMSCube_run.log.
- CI-friendly PASS/FAIL/SKIP and clearer logs.

Signed-off-by: Srikanth Muppandam <[email protected]>
This was referenced Sep 5, 2025
Closed
Closed
@smuppand
graphics: weston-simple-egl — robust Wayland env + optional FPS parsi…
582574d 
…ng; add print_path_meta()

weston-simple-egl:
- Resolve Wayland socket from env or scan common locations (/dev/socket/weston, /run/user/*).
- Start Weston if needed, adopt XDG_RUNTIME_DIR/WAYLAND_DISPLAY, verify with wayland-info.
- Run for configurable DURATION with timeout; try SIMPLE_EGL_FPS/WESTON_SIMPLE_EGL_FPS.
- If REQUIRE_FPS=1, gate on EXPECT_FPS±tolerance; else pass by duration only.
- CI logs include rc, elapsed, and FPS (when available). Write ./weston-simple-egl.res.

functestlib.sh:
- Add print_path_meta() to show owner/perms via stat, fixing ShellCheck SC2012 warnings.
- Keep adopt_wayland_env_from_socket() tidy to avoid SC2155 maskings.

Signed-off-by: Srikanth Muppandam <[email protected]>
@smuppand smuppand mentioned this pull request Sep 5, 2025
Closed
abbajaj806
abbajaj806 approved these changes Sep 6, 2025
View reviewed changes
Copy link
Contributor

@abbajaj806 abbajaj806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@abbajaj806 abbajaj806 merged commit 5f0e933 into qualcomm-linux:main Sep 6, 2025
8 checks passed
@smuppand smuppand linked an issue Sep 6, 2025 that may be closed by this pull request
'KMSCube' not found in PATH (In device usr/bin it showing) #153
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abbajaj806 abbajaj806 abbajaj806 approved these changes

@maheswaqcom maheswaqcom Awaiting requested review from maheswaqcom

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'KMSCube' not found in PATH (In device usr/bin it showing)

2 participants

@smuppand @abbajaj806