Added support for multiple arguments #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnarapar
force-pushed
the
main
branch
3 times, most recently
from
0e93439 to
139ae2f
Compare
smuppand
requested changes
Sep 8, 2025
smuppand
requested changes
Sep 8, 2025
Runner/run-test.sh
Outdated
|
|
||
| if [ "$#" -eq 0 ]; then | ||
| log "Usage: $0 [all | <testcase_name>]" | ||
| echo "Usage:" |
There was a problem hiding this comment.
Nit/UX: Please refactor the usage/help output
Right now we mix lines with several echos and print “Usage” twice. For CLI UX (and tooling), help should be a single, clean block printed to stderr, with a -h/--help path and clear exit codes.
There was a problem hiding this comment.
Updated as per comment to address clean block with help when -h/--help is given and added exit codes as suggested
vnarapar
force-pushed
the
main
branch
2 times, most recently
from
510091c to
91c9ec0
Compare
smuppand
requested changes
Sep 8, 2025
Runner/run-test.sh
Outdated
| print_usage() { | ||
| cat >&2 <<EOF | ||
| Usage: | ||
| $0 all |
Runner/run-test.sh
Outdated
| cat >&2 <<EOF | ||
| Usage: | ||
| $0 all | ||
| $0 <testcase_name> [arg1 arg2 ...] |
This change provides greater flexibility by allowing users to provide specific parameters to individual testcases from run-test.sh Signed-off-by: Vamsee Narapareddi <[email protected]>
smuppand
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change provides greater flexibility by allowing users to provide specific parameters to individual testcases from run-test.sh