Skip to content

Update fastrpc-premerge.yaml to use run.sh with --bin-dir /usr/local/bin #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

Update fastrpc-premerge.yaml to use run.sh with --bin-dir /usr/local/bin #168

merged 1 commit into from
Sep 17, 2025

Conversation

smuppand
Copy link
Contributor

This pull request updates the Runner/plans/fastrpc-premerge.yaml plan to invoke run.sh with the --bin-dir argument set to /usr/local/bin.

Details:

  • Modified the run.sh command to include --bin-dir /usr/local/bin.
  • Ensures binaries are executed from the correct directory during pre-merge checks.
  • Improves consistency with deployment and runtime environments.

Impact:

  • Pre-merge validation now uses binaries from /usr/local/bin.
  • Reduces risk of path-related issues in CI/CD workflows.

@smuppand smuppand requested a review from abbajaj806 September 17, 2025 09:21
@smuppand smuppand marked this pull request as ready for review September 17, 2025 09:22
@smuppand smuppand requested a review from vnarapar September 17, 2025 09:28
@vnarapar
Copy link
Contributor

can u please add the commit details

vnarapar
vnarapar approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@vnarapar vnarapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

abbajaj806
abbajaj806 approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@abbajaj806 abbajaj806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@abbajaj806 abbajaj806 merged commit c7f1e4f into qualcomm-linux:main Sep 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vnarapar vnarapar vnarapar approved these changes

@abbajaj806 abbajaj806 abbajaj806 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smuppand @vnarapar @abbajaj806