Skip to content

fastrpc_test: default to /usr/local/bin and set LD_LIBRARY_PATH for local libs #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2025
Merged

fastrpc_test: default to /usr/local/bin and set LD_LIBRARY_PATH for local libs #169

merged 1 commit into from
Sep 18, 2025

Conversation

smuppand
Copy link
Contributor

What changed

  • Default binary location: --bin-dir now defaults to /usr/local/bin (was /usr/bin).
  • Library path: export LD_LIBRARY_PATH=/usr/local/lib/fastrpc_test before launching the test so bundled libs are found.
  • Help text & logs: updated notes and messages to reflect the new default path.
  • Safety check: existing /bin guard retained; message updated to suggest /usr/local/bin.

Why

  • fastrpc_test and its libs are being installed under /usr/local; this makes the runner work out-of-the-box without extra flags.
  • Ensures the test picks up its companion libs from /usr/local/lib/fastrpc_test.

Backward compatibility

  • Users can still override with --bin-dir (e.g., /usr/bin).
  • ALLOW_BIN_FASTRPC=1 still permits /bin/fastrpc_test.
  • Default invocation (no flags)
  • export LD_LIBRARY_PATH=/usr/local/lib/fastrpc_test
  • (cd /usr/local/bin && ./fastrpc_test -d -t linux -U 0)

@smuppand
fastrpc_test: default to /usr/local/bin; set LD_LIBRARY_PATH for loca…
2227f64 
…l libs

- Change default --bin-dir to /usr/local/bin (was /usr/bin).
- Export LD_LIBRARY_PATH=/usr/local/lib/fastrpc_test before running so
  ./fastrpc_test resolves its companion libs.
- Update help text and warnings to reference /usr/local defaults.
- Keep existing logic: cd into bin dir, honor --bin-dir overrides, and
  retain /bin guard with ALLOW_BIN_FASTRPC=1 escape hatch.

Signed-off-by: Srikanth Muppandam <[email protected]>
@smuppand smuppand marked this pull request as ready for review September 18, 2025 05:21
abbajaj806
abbajaj806 approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@abbajaj806 abbajaj806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@abbajaj806 abbajaj806 merged commit f4a7965 into qualcomm-linux:main Sep 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abbajaj806 abbajaj806 abbajaj806 approved these changes

@quic-mtharu quic-mtharu Awaiting requested review from quic-mtharu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smuppand @abbajaj806