Skip to content

fastrpc_test: export ASSETS_DIR for back-compat, silence ShellCheck SC2034 #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2025
Merged

fastrpc_test: export ASSETS_DIR for back-compat, silence ShellCheck SC2034 #170

merged 1 commit into from
Sep 18, 2025

Conversation

smuppand
Copy link
Contributor

Why

  • Our fastrpc_test runner moved to the /usr/local layout and no longer uses --assets-dir.
  • ShellCheck now flags ASSETS_DIR as unused (SC2034).
  • Some legacy wrappers may still pass --assets-dir and expect the variable to be visible to child processes.

What changed

  • After argument parsing, if --assets-dir was provided, we now:
  • export ASSETS_DIR
  • log a single compat line: (compat) --assets-dir provided: … (ignored with /usr/local layout)
  • No functional changes to execution, arguments, pass/fail logic, or environment setup beyond exporting the variable.

@smuppand
fastrpc_test: export ASSETS_DIR for back-compat; silence SC2034
78e2929 
Keep accepting --assets-dir for legacy callers, but in the new /usr/local layout it’s ignored.
Export ASSETS_DIR after arg parsing so ShellCheck no longer flags it as unused and so external wrappers can still read it.
Revert the CLI parameter from fastrpc yaml file.

- Export ASSETS_DIR if provided
- Add a single compat log line (no behavior change)

Signed-off-by: Srikanth Muppandam <[email protected]>
abbajaj806
abbajaj806 approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@abbajaj806 abbajaj806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me

@abbajaj806 abbajaj806 merged commit 449ba39 into qualcomm-linux:main Sep 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abbajaj806 abbajaj806 abbajaj806 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smuppand @abbajaj806