Audio: Add Network Bring-Up and Fix SKIP Handling #172
Conversation
|
Hi @smuppand, Thank you for the detailed suggestions and refined implementations. I've reviewed and incorporated the updated versions of check_network_status_rc, net_log_iface_snapshot, and ensure_network_online as per your recommendations. Please let me know if there is anything else that needs to be addressed. |
Please resolve the conversations where you have already addressed. |
I have resolved all the review comments and updated the code according to your suggestions. Please review it now. |
README has been updated to include the new enhancements, including documentation for Wi-Fi credential support and network probe environment variables. Let me know if anything else needs to be added. |
| - Logs include dmesg snapshots, mixer dumps, and playback logs. | ||
| - Asset download requires network connectivity. | ||
| - Pass Wi-Fi credentials via SSID and PASSWORD environment variables to enable network access for asset downloads and playback validation. | ||
| - You can override default network probe targets using NET_PROBE_ROUTE_IP and NET_PING_HOST to avoid connectivity-related failures in restricted environments. |
There was a problem hiding this comment.
It would be helpful to include a few examples showing how users can override these parameters, either using the CLI or environment variables.
There was a problem hiding this comment.
It would be helpful to include a few examples showing how users can override these parameters, either using the CLI or environment variables.
I've added examples for overriding network-related parameters and Wi-Fi credentials using environment variables. Please let me know if any further changes are needed.
- Added generic network bring-up with interface checks. - Centralized audio asset fetching logic. - Updated playback script to SKIP when offline and corrected the final status. Signed-off-by: Teja Swaroop Moida <[email protected]>
2 participants
This PR fixes #171