Skip to content

Conversation

smuppand
Copy link
Contributor

@smuppand smuppand commented Oct 6, 2025

Introduces top-level vs sub-run gating in run.sh so heavy operations run once per --stack both execution:

  • ensure_rootfs_min_size
  • initial network bring-up (ensure_network_online)
  • early media bundle fetch/extract

Adds robust post-stack capture in run.sh:

  • video_dump_stack_state before/after
  • whitespace-safe normalization of post_stack with fallback to video_stack_status when unknown

Keeps Kodiak firmware handling safe and minimal:

  • upstream FW install done once per pass

  • downstream reload only when requested/needed, with existing lib_video.sh helpers

  • Preserves CLI and logic; no renames, no one-liners. Logging now explicitly states when sub-runs skip costly steps (e.g., “Sub-run: skipping rootfs size check”).

lib_video.sh enhancements leveraged:

  • retrying modprobe, runtime block/unblock, persistent blacklist handling, V4L node refresh, FW swap/reload helpers

  • functestlib.sh & YAML: no interface changes; existing helpers (check_dependencies, extract_tar_from_url, ensure_rootfs_min_size, scan_dmesg_errors) used as-is.

Verification

  • Example --stack both run shows single early fetch, sub-runs skip heavy steps, clear pre/post module dumps, clean dmesg triage, and PASS for all tests in both passes.

Compatibility & Risk

  • Backwards compatible flags and defaults.
  • Writes to /etc/modprobe.d remain intentional and idempotent.
  • Requires root for module ops (existing requirement).

@smuppand smuppand changed the title IRIS Video: stabilize stack switching & avoid duplicate heavy ops in --stack both; cleaner logs and safer Kodiak FW flow IRIS Video: stabilize stack switching & avoid duplicate heavy ops in --stack both, cleaner logs and safer Kodiak FW flow Oct 6, 2025
@smuppand smuppand force-pushed the video-fix branch 2 times, most recently from bdb37ff to eb3179c Compare October 6, 2025 17:16
…y guards for rootfs check, early bundle fetch, FW ops.

 - Prevent duplicate rmmod/modprobe cycles and reduce kernel panic risk.
 - Harden modprobe/insmod with retries and persistent de-blacklist.
 - Kodiak: install upstream FW on base; apply downstream FW override once.
 - Preserve pre/post stack dumps and V4L node refresh; better dmesg hints.
 - lib_video.sh: robust clip discovery/fetch and ensure app executable.
 - run.sh/functestlib.sh/YAML: expose tunables and idempotent downloads.

Signed-off-by: Srikanth Muppandam <[email protected]>
Copy link
Contributor

@abbajaj806 abbajaj806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abbajaj806 abbajaj806 merged commit 115d9af into qualcomm-linux:main Oct 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants