IRIS runner: add default app/firmware fallbacks and path probing (no logic changes) #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
smuppand
commented
Oct 7, 2025
smuppand
commented
- Respect --app when provided; otherwise resolve iris_v4l2_test by probing: $PATH, then /usr/bin/iris_v4l2_test, then /data/vendor/iris_test_app/iris_v4l2_test.
- For Kodiak downstream/overlay runs, if --downstream-fw is not passed, automatically use /data/vendor/iris_test_app/firmware/vpu20_1v.mbn when present.
- Emit clear logs showing which app/firmware path was selected to aid triage.
- No renames, no behavioral logic changes to the runner flow; only path resolution was added.
- Backwards compatible: existing CLI overrides still win; upstream-only builds continue to work.
- Prefer user-specified --app; otherwise search PATH, then /usr/bin/iris_v4l2_test, then /data/vendor/iris_test_app/iris_v4l2_test. - For Kodiak downstream, if --downstream-fw is not given, auto-use /data/vendor/iris_test_app/firmware/vpu20_1v.mbn when present. - Keep existing names/logic; only path resolution and default selection updated. - Log which app/firmware paths are chosen to aid debugging. - No changes to test flow, results, or stack-switch behavior. Signed-off-by: Srikanth Muppandam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.