resource-tuner(run.sh): start service only when needed with guard systemctl ops #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smuppand
changed the title
vnarapar
reviewed
Oct 9, 2025
| # - Else -> overall SKIP (everything skipped) | ||
| if [ "$FAIL" -gt 0 ]; then | ||
| echo "$TESTNAME FAIL" >"$RES_FILE" | ||
| exit 0 |
There was a problem hiding this comment.
Updated in the latest
|
Can you check if the commit message needs all the cgroups |
Removed the unwanted messages from the commit message. |
1 similar comment
Removed the unwanted messages from the commit message. |
- Check current state first (systemctl is-active/is-enabled) skip if active. - Enable only when disabled, run daemon-reload before attempting start. - Start only if not running, always print final - Avoid redundant enable/start calls, reduces noise and race risk. - Preserve existing PASS/SKIP policy and names, no logic changes to tests. - Replace prior one-liners with readable multi-line flow (no behavioral change). Signed-off-by: Srikanth Muppandam <[email protected]>
smuppand
force-pushed
the
resource-tuner
branch
2 times, most recently
from
0c95e7c to
d9bc98f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hardens the resource-tuner runner’s service handling without changing any existing test logic or names.
Key changes:
systemctl is-active/is-enabled) and skip redundant actions.systemctl daemon-reloadbefore enable/start, then:systemctl status resource-tunerfor visibility.systemctlis unavailable, emit a clear warning and continue (no hard fail).Why: