Skip to content

Conversation

smuppand
Copy link
Contributor

@smuppand smuppand commented Oct 8, 2025

What this PR brings in to address #186 & #188

  • Add --ssid/--password to WiFi_Dynamic_IP; preserve existing credential resolution.
  • Add --ssid/--password to WiFi_Manual_IP; same fallback behavior.
  • Expand one-liners to multi-line; no logic changes or exports of secrets.
  • CI logging: report iface, acquired IP, ping command, and ping output in Dynamic_IP.
  • Keep nmcli and wpa_supplicant+udhcpc paths, retries, and gating unchanged.
  • Add functestlib:get_remoteproc_path_by_firmware(); integrate with WiFi_Firmware_Driver.
  • Fixes "command not found" and validates wpss remoteproc on Kodiak/RB3gen2.
  • Backward compatible with ssid_list/env; no behavior change when flags unused.
  • Idempotent, readable, and safe to re-run across CI/CD.

…re_Driver

Problem
- WiFi_Firmware_Driver failed with: `get_remoteproc_path_by_firmware: command not found`.
- The runner expects a helper to resolve the remoteproc sysfs path for a given firmware
  (e.g., `wpss.mbn` on Kodiak/qcm6490/WCN6750), but the function was missing.

Signed-off-by: Srikanth Muppandam <[email protected]>
- Accepts new CLI flags: --ssid <SSID> and --password <PASS>.
- If provided, these override positional args; otherwise falls back to the
  existing get_wifi_credentials resolution (args/env/ssid_list).
- Converted inline one-liners to multi-line commands for readability while
  preserving behavior (nmcli path, wpa_supplicant+udhcpc path, ping checks).
- No exports of SSID/PASSWORD kept values local to the script.
- No changes to connection logic, retries, gating, or result reporting.

Signed-off-by: Srikanth Muppandam <[email protected]>
…liners

- Introduce explicit credential flags: --ssid <SSID> and --password <PASS>.
- When provided, flags take precedence over positional args; otherwise
  continue to resolve via get_wifi_credentials(,) (args/env/ssid_list).

Signed-off-by: Srikanth Muppandam <[email protected]>
Copy link
Contributor

@abbajaj806 abbajaj806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abbajaj806 abbajaj806 merged commit f52cb54 into qualcomm-linux:main Oct 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants