Skip to content

Audio init + Playback/Record hardening: platform logs, network parity, asset checks, and exit codes #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2025
Merged

Audio init + Playback/Record hardening: platform logs, network parity, asset checks, and exit codes #190

merged 3 commits into from
Oct 10, 2025

Conversation

smuppand
Copy link
Contributor

@smuppand smuppand commented Oct 9, 2025 •
edited
Loading

This PR is going to enhance as per the #187

  • init_env

    • Robustly detect and export ROOT_DIR/TOOLS and mark idempotent load to ensure detect_platform & helpers are available in tests.
    • Silences ShellCheck hints for sourced utils without changing behavior.

  • AudioPlayback

    • Logs platform details via detect_platform; aligns network bring-up/rootfs size checks with Video (including optional Wi-Fi creds).
    • Adds pre-fetch content checks and richer asset fetch/extract logging.
    • Keeps existing flow/evidence checks; expands one-liners; fixes ShellCheck sourcing.
    • Proper exit codes: 0=PASS, 1=FAIL, 2=SKIP.

  • AudioRecord

    • Adds distinct exit codes (0/1/2) and fixes ShellCheck issues (SC1091, SC1010, rc=$?).
    • Multiline readability and platform detail logging, with no logic changes.

@smuppand
init_env: robust root discovery & idempotent load
9fb2dd9 
- Add __INIT_ENV_LOADED guard to prevent double sourcing.
- Detect ROOT_DIR (CWD or walk-up) and export TOOLS/paths.
- Quietly source utils; fail fast if utils/functestlib.sh missing.
- Fix empty so platform/network helpers are available.

Signed-off-by: Srikanth Muppandam <[email protected]>
@smuppand
AudioPlayback: add Wi-Fi CLI, platform+network preflight, rootfs chec…
9bf03fd 
…k; improve asset logging & exits

- Introduce --ssid/--password (no exports); keep existing flow and names.
- Print platform details via detect_platform, no new files/functions.
- Align with video: rootfs >=2GiB gate, network status/bring-up with NET_STABILIZE_SLEEP and TOP_LEVEL_RUN.
- Before fetching, check for existing clip, log source URL and final size. keep audio_ensure_clip_ready behavior.
- Proper exit codes (PASS/SKIP=0, FAIL=1) multi-line refactors, address ShellCheck SC1091/SC2034 without logic changes.

Signed-off-by: Srikanth Muppandam <[email protected]>
@smuppand
AudioRecord: add PASS/FAIL/SKIP exit codes, fix ShellCheck, multiline…
beec7f4 
…, platform log

- Return distinct exit codes (0=PASS, 1=FAIL, 2=SKIP) to align with harness.
- Fix ShellCheck issues: SC1091 (sourcing), SC1010 (‘; then’), SC2124 (rc=0).
- Expand one-liners to multi-line for readability; no behavioral changes.
- Log platform details via detect_platform (with safe fallback to ‘unknown’).

Signed-off-by: Srikanth Muppandam <[email protected]>
abbajaj806
abbajaj806 approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@abbajaj806 abbajaj806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abbajaj806 abbajaj806 merged commit 72cf028 into qualcomm-linux:main Oct 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abbajaj806 abbajaj806 abbajaj806 approved these changes

Assignees

@vnarapar vnarapar

@abbajaj806 abbajaj806

@Vkenjam Vkenjam

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smuppand @abbajaj806 @vnarapar @Vkenjam