Skip to content

functestlib: harden extract_tar_from_url for minimal builds & flaky TLS #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2025
Merged

functestlib: harden extract_tar_from_url for minimal builds & flaky TLS #191

merged 2 commits into from
Oct 13, 2025

Conversation

smuppand
Copy link
Contributor

@smuppand smuppand commented Oct 10, 2025 •
edited
Loading

  • Skip redundant fetches via “already extracted” detection (marker file + archive entry sniff).
  • New downloader cascade: curl → aria2c → wget, with BusyBox wget fallback and --no-check-certificate path when OpenSSL is missing.
  • Detect bad system clock (ensure_reasonable_clock); treat as limited network and return 2 (SKIP) instead of failing.
  • Support absolute paths and file:// URLs; write a .extracted success marker after unpack.
  • Keep all original var names and multi-line style; no API changes to callers.
  • Clear logging for presence checks, downloads, and extraction verification.
  • Standardized returns: 0=OK, 1=error, 2=limited-network/skip.

@smuppand
functestlib: harden extract_tar_from_url for minimal builds & limited…
87c0b78 
… TLS

- Add “already extracted” detection (marker file + entry sniff) to skip refetch.
- New downloader cascade: curl → aria2c → wget, with BusyBox wget fallback and --no-check-certificate path when OpenSSL is absent.
- Detect bad system clock via ensure_reasonable_clock; treat as limited-network and return 2 (skip) instead of hard fail.
- Support absolute and file:// URLs; keep all original var names and multi-line style.
- Improved logging and success marker (.extracted); verify at least one extracted entry exists.
- Standardize return codes: 0=OK, 1=error, 2=limited-network/skip; no changes required in callers.

Signed-off-by: Srikanth Muppandam <[email protected]>
@smuppand
AudioPlayback: source lib_video.sh to enable video_step
1ffc3c0 
- Add `. "$TOOLS/lib_video.sh"` after audio_common sourcing.
- Fixes runtime error: `video_step: not found` on AudioPlayback runs.
- Reuses existing video helpers (e.g., video_step) for consistent logging.

Signed-off-by: Srikanth Muppandam <[email protected]>
abbajaj806
abbajaj806 approved these changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@abbajaj806 abbajaj806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abbajaj806 abbajaj806 merged commit a7abd8d into qualcomm-linux:main Oct 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abbajaj806 abbajaj806 abbajaj806 approved these changes

@vnarapar vnarapar Awaiting requested review from vnarapar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smuppand @abbajaj806