Added missing weston/wayland and display helpers with diagnostics #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
smuppand
commented
Oct 12, 2025
smuppand
commented
- Introduces Weston/Wayland helpers in functestlib: socket discovery, env adoption, connection check.
- Uses sysfs-only DRM connector probing; no modetest dependency.
- Adds display_debug_snapshot for clear, minimal-build-friendly diagnostics.
- wayland_choose_or_start adopts existing Weston (handles different users) without headless backend.
- weston-simple-egl/run.sh rewritten to multi-line with clear logs and result file.
- Enforces PASS/FAIL/SKIP semantics (0/1/2) and skips when no monitor connected.
- Robust runtime: prefers run_with_timeout, falls back to timeout or manual stop.
- Best-effort FPS parsing; optional gating via REQUIRE_FPS and tolerance thresholds.
- Dense debugging: logs PIDs, sockets, env exports, connectors, and weston outputs.
- ShellCheck cleanups applied; no functional regressions to existing callers.
…d richer debug - New helpers: weston_pids, weston_is_running, find_wayland_sockets, wayland_pick_socket, adopt_wayland_env_from_socket, wayland_connection_ok, wayland_choose_or_start, wayland_debug_snapshot. - Socket discovery across /run/user/<uid>, /run/user/*, /dev/socket/weston, /tmp; no hardcoded UID. - Prefer pgrep; fallback to portable ps+awk (minimal-build friendly). - Remove headless backend spawn logic, weston_start only tries systemd and otherwise returns non-zero. - Minimal-build safe: no hard deps (wayland-info/weston-info optional with fallbacks). - Debug snapshot logs ps/cmdline, socket stat, and reproducible `export` hints. Signed-off-by: Srikanth Muppandam <[email protected]>
smuppand
force-pushed
the
graphics
branch
2 times, most recently
from
a62f6da to
55dab1d
Compare
…FAIL/SKIP - Convert to multiline with concise, actionable log_info for debugging. - Use wayland_choose_or_start + adopt_wayland_env_from_socket log final env and export hints. - Keep compositor-agnostic behavior no headless assumptions; works on minimal builds. - Standardize results: write .res and exit codes (PASS=0, FAIL=1, SKIP=2). - Use run_with_timeout if present, else coreutils timeout, else manual sleep/kill, log elapsed. - Best-effort FPS parsing, optional tolerance gate when REQUIRE_FPS=1 no change to default semantics. Signed-off-by: Srikanth Muppandam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.