Added minor timer script fix #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smuppand
requested changes
Oct 13, 2025
smuppand
requested changes
Oct 14, 2025
| BINARY_PATH="" | ||
| while [ $# -gt 0 ]; do | ||
| case "$1" in | ||
| --binary-path=*) |
There was a problem hiding this comment.
It would be helpful to include help and usage information when supporting new CLI parameters, so users can easily see what options are available.
There was a problem hiding this comment.
Updated as per comments to add the help and usage information
| if [ $? -ne 0 ]; then | ||
| log_skip "$TESTNAME : Binary '$BINARY' not found" | ||
| echo "$TESTNAME SKIP" > "$res_file" | ||
| exit 1 |
There was a problem hiding this comment.
Would you prefer to have it fail if the binary is not available? Alternatively, we could exit gracefully with exit 0 instead of exit 1.
There was a problem hiding this comment.
Added SKIP with exit 0
Added minor fix to timer testcase to pdate the binary execution path and to print the complete output for easy debug Signed-off-by: Vamsee Narapareddi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added minor fix to timer testcase to pdate the binary execution path and to print the complete output for easy debug