Minor fix for DSP test #195
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smuppand
requested changes
Oct 14, 2025
This commit addresses the timing issue to run adsprpcd binary - Here call trace now will accurately show the output - Cleanup is done smoothly Signed-off-by: Vamsee Narapareddi <[email protected]>
smuppand
requested changes
Oct 14, 2025
| return 1 | ||
| } | ||
|
|
||
| kill_process() { |
There was a problem hiding this comment.
- This is very very basic, Better you extend it to cover
- Returns 0 if all targets are gone (or nothing was running).
- Returns 1 if any target could not be terminated.
- Sends SIGTERM first, waits KILL_TERM_GRACE seconds, then SIGKILL, waits KILL_KILL_GRACE seconds.
- Kills children too (via /proc/.../children), and attempts a process-group kill when possible.
- Safe-guards: never touches PID 1 or self ($$), gracefully handles zombies and non-children (no blocking wait calls).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the timing issue to run adsprpcd binary