Add FastCV OpenCV SFM validation test script #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script performs rootfs resizing, sets permissions for OpenCV binaries, installs required IPK packages, and runs the OpenCV SFM test suite with performance parameters. It validates the output to ensure all 19 tests pass. Signed-off-by: Anil Yadav <[email protected]>
|
Please ensure that script has required execute permissions |
vnarapar
reviewed
Oct 14, 2025
| # shellcheck disable=SC1090,SC1091 | ||
| . "$TOOLS/functestlib.sh" | ||
|
|
||
| TESTNAME="fastCV" |
There was a problem hiding this comment.
Change to FastCV as dir structure is different
vnarapar
reviewed
Oct 14, 2025
|
|
||
| # Step 3: Install IPK packages | ||
| log_info "Installing IPK packages from /usr/bin/FastCV/opencv..." | ||
| cd /usr/bin/FastCV/opencv || exit 1 |
There was a problem hiding this comment.
Please add some debug logs before exit so that it will be easy for debugging
smuppand
requested changes
Oct 14, 2025
|
|
||
| # Step 1: Resize rootfs | ||
| log_info "Resizing rootfs partition..." | ||
| resize2fs /dev/disk/by-partlabel/rootfs |
There was a problem hiding this comment.
Please use available functions
qcom-linux-testkit/Runner/utils/functestlib.sh
Line 3399 in 59365c8
| # Step 2: Set permissions | ||
| log_info "Setting permissions for OpenCV binaries..." | ||
| chmod 777 /usr/bin/FastCV/opencv | ||
| chmod 777 /usr/bin/opencv* |
There was a problem hiding this comment.
It would be better to review the current execute permissions first, rather than immediately assigning 777 without checking.
| # Step 3: Install IPK packages | ||
| log_info "Installing IPK packages from /usr/bin/FastCV/opencv..." | ||
| cd /usr/bin/FastCV/opencv || exit 1 | ||
| opkg install *.ipk |
There was a problem hiding this comment.
How do you determine if any ipk failed to install?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FastCV OpenCV SFM validation test script
This script performs rootfs resizing, sets permissions for OpenCV binaries,
installs required IPK packages, and runs the OpenCV SFM test suite with
performance parameters. It validates the output to ensure all 19 tests pass.
Signed-off-by: Anil Yadav [email protected]