Skip to content

Conversation

smuppand
Copy link
Contributor

What

  • Make [run.sh](http://run.sh/) fully dynamic: parse media graph at runtime (no hardcoded nodes), per-pipeline capture, multi-format support, PASS/FAIL/SKIP summary + .res.
  • Harden helpers in [functestlib.sh](http://functestlib.sh/): keep MBUS on pads (strip trailing P), PIXEL fmt on video node, update only WxH, and link reliably.
  • Add resilience: media reset + single retry, auto mplane detection, plane-model flip (capturecapture-mplane), packed↔unpacked fallback (SRGGB10SRGGB10P), and clear exit codes.

Why

Manual media-ctl (pads=SRGGB10) + yavta (video=SRGGB10P) succeeded while the script pushed *P to pads and failed. This fixes pad/video fmt split, quoting, and timing/race sensitivities.

How to debug

  • Enable planned command echo: PRINT_PLANNED=1 ./[run.sh](http://run.sh/) (logs the exact media-ctl/yavta sequence).
  • Optional sensor register writes remain guarded: ALLOW_SENSOR_CTRL=1 to enable pre/post yavta --no-query -w ....

Usage

  • ./[run.sh](http://run.sh/) --format SRGGB10P --frames 10
  • Defaults: auto-detected format from pipeline, one retry after media-ctl -r.

Compatibility / Notes

  • No board-specific strings, works across CAMSS variants where the media graph exposes RDI pipelines.
  • Fails overall only if any pipeline fails, missing binaries or unsupported formats are reported as SKIP.

Parse media graph at runtime (no hardcoded nodes/formats); per-pipeline auto-detect.
Keep MBUS on pads and PIXEL on video; support multi-format and .res PASS/FAIL/SKIP.
Add one retry after media reset; optional planned-commands logging for debugging.

Signed-off-by: Srikanth Muppandam <[email protected]>
configure_pipeline_block keeps MBUS on pads (strip trailing 'P'); updates WxH only.
execute_capture_block adds mplane detection, packed↔unpacked + plane-flip fallbacks.
Fix case quoting and strict quoting; remove non-POSIX 'local'; MEDIA_LINK_FILTER=all.

Signed-off-by: Srikanth Muppandam <[email protected]>
Copy link
Contributor

@abbajaj806 abbajaj806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abbajaj806 abbajaj806 merged commit e49d314 into qualcomm-linux:main Oct 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants