Centralize stdout/stderr capture in init_env and make run-test.sh inherit unified log #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnarapar
reviewed
Oct 16, 2025
vnarapar
reviewed
Oct 16, 2025
vnarapar
reviewed
Oct 16, 2025
vnarapar
reviewed
Oct 16, 2025
vnarapar
reviewed
Oct 16, 2025
- Add optional global tee capture controlled by RUN_STDOUT_ENABLE/… env vars. - Create timestamped (under or ROOT_DIR/logs). - Export the same file so child run.sh scripts append to one unified log. - Install trap to restore FDs on exit; idempotent guard prevents double-capture. Signed-off-by: Srikanth Muppandam <[email protected]>
- Source ./init_env first so global tee is activated once per session. - Remove any per-script capture logic; rely on exported RUN_STDOUT_FILE. - Ensure child ./run.sh inherits the environment unchanged (no semantic changes). - Minor cleanup to avoid duplicate env setup; logging remains via functestlib. Signed-off-by: Srikanth Muppandam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a single, CI-friendly stdout/stderr capture mechanism that is enabled once in
init_envand automatically used by both per-suite[run.sh](http://run.sh/)and the top-level[run-test.sh](http://run-test.sh/). No changes are required in individual tests.What changed
init_env
teecapture with idempotent guard (no double capture when scripts re-source).run-test.sh
init_envfirst so the unified capture is active before spawning tests.[run.sh](http://run.sh/)inherits the same environment.