This PR integrates all shell scripts from qcom-linux-testkit-sources into the qcom-linux-testkit build system using autotools. #26
Conversation
src/tests/reboot.c
Outdated
| @@ -0,0 +1,131 @@ | |||
| /* | |||
There was a problem hiding this comment.
Is there a reason why these tests are written in C? It looks like they can be rewritten in shell and there would be no need for compilation.
There was a problem hiding this comment.
Is there a reason why these tests are written in C? It looks like they can be rewritten in shell and there would be no need for compilation.
This was initially written for Axiom, and as a short-term enablement, we switched to Lava. It may not be required for now, but we will need it in the long term.
There was a problem hiding this comment.
Could you explain how it works in axiom? I don't see any service running these programs on bootup or anything similar.
There was a problem hiding this comment.
setup_systemd.sh will set up the necessary systemd-service to test the reboot functionality. The .c code will also perform some health checks after the service initialization.
There was a problem hiding this comment.
I don't see setup_systemd.sh in this PR. Even with that it still doesn't explain why these need to be compiled. There is no API they call that can't be used from shell.
There was a problem hiding this comment.
Based on this, I don't think these C files belong in this repository.
There was a problem hiding this comment.
I'm not sure why these can't be included in this repository, especially since they'll be useful when we migrate to Axiom in the future.
There was a problem hiding this comment.
You can include them when they're useful. For the moment they're not and can be rewritten in shell. Adding dependencies is not a great idea.
There was a problem hiding this comment.
If we are not using these files at this time, then let's not include them. Unused code is going to be a burden to someone and confusing for any developers without context.
smuppand
force-pushed
the
main
branch
4 times, most recently
from
ef9dd04 to
e5363e9
Compare
3 participants
Changes
Motivation
Combining C sources and shell scripts under a single build system makes the test kit easier to distribute, install, and maintain across environments.
Test Plan
./autogen.sh,./configure,make, andmake installsuccessfully@mwasilew @craigez