Add KMScube & WestonSimpleEGL Test for Graphics Public CI #40
Conversation
|
@mwasilew @smuppand @abbajaj806 Could you please review this PR ? |
| # Import common functions | ||
| . "$(pwd)/init_env" | ||
| . "$TOOLS/functestlib.sh" | ||
|
|
There was a problem hiding this comment.
Since the shellcheck recommends ^-- SC1090: Can't follow non-constant source. Use a directive to specify location. Better we define it like below
. /var/qcom-linux-testkit/init_env
. /var/qcom-linux-testkit/utils/functestlib.sh
There was a problem hiding this comment.
This doesn't work if you don't install the suite in this location. When running LAVA jobs it's exactly the case. I propose to ignore "can't follow" warning.
There was a problem hiding this comment.
This is what we are asking in readme.md file. To copy this in /var/ folder.
git clone
cd
scp -r common Runner user@<target_device_ip>:/var
ssh user@<target_device_ip>
cd /var/Runner && ./run-test.sh cpufreq
There was a problem hiding this comment.
It's not always the case when running the tests.
| log_info "------------------- Starting $TESTNAME Testcase ----------------------------" | ||
|
|
||
| # Validate if kmscube binary is available | ||
| if ! command -v kmscube >/dev/null 2>&1; then |
There was a problem hiding this comment.
https://github.com/qualcomm-linux/qcom-linux-testkit/blob/main/Runner/utils/functestlib.sh#L37 use this defined function for check_dependencies ()
| fi | ||
|
|
||
| # Check if DRM device exists | ||
| if [ ! -e /dev/dri/card0 ]; then |
There was a problem hiding this comment.
Move these device checks to functestlib.sh, as they are common functions that others might also need to use.
| exit 1 | ||
| fi | ||
|
|
||
| # Print result helper |
There was a problem hiding this comment.
As you are importing functionslib.sh. Better use log_pass, log_fail from https://github.com/qualcomm-linux/qcom-linux-testkit/blob/main/Runner/utils/functestlib.sh#L55
| : > "$LOG_FILE" | ||
|
|
||
| # Run kmscube and log output | ||
| /usr/bin/kmscube --device /dev/dri/card0 --count="$FRAME_COUNT" 2>&1 | tee -a "$LOG_FILE" |
There was a problem hiding this comment.
prefer command -v kmscube or let $PATH handle it.
| #!/bin/sh | ||
| # SPDX-License-Identifier: BSD-3-Clause-Clear | ||
| # Description: Script to test the 'weston-simple-egl' Wayland client for 30 seconds and log the result. | ||
|
|
There was a problem hiding this comment.
above recommendations are applicable to this file as well.
|
@maheswaqcom please rebase and resolve the conficts. |
5 participants
Description:
This script automates the validation of KMSCube & WestonSImpleEGL Graphics Tests
kmscube:
A simple OpenGL ES demo that renders a rotating cube using the Linux kernel mode-setting (KMS) and direct rendering manager (DRM) APIs. It showcases rendering without a windowing system like X or Wayland.
weston-simple-egl:
A basic EGL and OpenGL ES demo client for the Weston Wayland compositor. It renders a spinning cube to demonstrate EGL context creation and buffer swapping in a Wayland environment.