Fix remaining shellcheck warnings #44
Conversation
Fix warnings and errors in remaining files. Where errors are unavoidable add suitable exceptions, like in the platform.sh script. Signed-off-by: Milosz Wasilewski <[email protected]>
| if [ "$device_count" -eq 0 ]; then | ||
| log_fail "$TESTNAME : Test Failed - No USB devices found." | ||
| echo "$TESTNAME FAIL" > $test_path/$TESTNAME.res | ||
| log_fail "$TESTNAME : Test Failed - No USB devices found." |
There was a problem hiding this comment.
Is log_fail supposed to change to log_error?
There was a problem hiding this comment.
The only change I made was removing the non-printable UTF character. I don't want to change the actual content of the script.
There was a problem hiding this comment.
Oh I see. I saw that log function names had changed and you wanted to fix that. Let me cross-check that on my end and fix if needed,
There was a problem hiding this comment.
if you can fix the issues you mentioned I can rebase this patch on top and avoid the changes altogether.
There was a problem hiding this comment.
I cross-checked the log function names in functestlib.sh and they are the same as written in my script. So we're good and additional changes are not required.
3 participants
Fix warnings and errors in remaining files. Where errors are unavoidable add suitable exceptions, like in the platform.sh script.