Public CI Video Decode and Encode Shell Scripts. #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbajaj806
requested review from
mwasilew,
smuppand and
vnarapar
and removed request for
mwasilew
mwasilew
requested changes
May 23, 2025
| # Extract the filename from the URL | ||
| filename=$(basename "$url") | ||
| if [ -f "$filename" ]; then | ||
| return 0 |
Runner/utils/functestlib.sh
Outdated
| # Extract the filename from the URL | ||
| filename=$(basename "$url") | ||
| if check_tar_file "$filename"; then | ||
| echo "[PASS] file already exists, Hence skipping downloading" |
|
|
||
| #import test functions library | ||
| . $TOOLS/functestlib.sh | ||
| # shellcheck souce=../../../../utils/functestlib.sh |
|
|
||
| #import test functions library | ||
| . $TOOLS/functestlib.sh | ||
| # shellcheck souce=../../../../utils/functestlib.sh |
Runner/utils/functestlib.sh
Outdated
| filename=$(basename "$url") | ||
| if check_tar_file "$filename"; then | ||
| echo "[PASS] file already exists, Hence skipping downloading" | ||
| return 1 |
There was a problem hiding this comment.
The return codes are really confusing. Sometimes 1 means OK and sometimes it means failure. I propose to return 0 always when there is no problem and use non-zero codes when there are issues.
Runner/utils/functestlib.sh
Outdated
|
|
||
| if ping -c 1 -W 2 8.8.8.8 >/dev/null 2>&1; then | ||
| echo "[PASS] Internet is reachable." | ||
| return 1 |
There was a problem hiding this comment.
Return codes in this function are reversed.
When suite is run from a different directory than /var/ functions won't be able to find tests by name. This patch fixes the issue and allows to discover tests that are executed from current path. Signed-off-by: Milosz Wasilewski <[email protected]>
Implemented shell scripts for public CI for Decode and Encode Scenarios. Added Video encode test script Added Video decode test script Added readme document for video validation Implemented Function for ActiveIP Implemented Function for wget pull resource Implemented Function for untar of resource Implemented Function to check if file is already present or not Signed-off-by: Abhishek Bajaj <[email protected]>
|
Some Rebase issue. Will raise another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented shell scripts for public CI for Decode and Encode Scenarios.
Added Video encode test script
Added Video decode test script
Added readme document for video validation
Implemented Function for ActiveIP
Implemented Function for wget pull resource
Implemented Function for untar of resource
Implemented Function to check if file is already present or not