test script for systemd validation #50
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
@avisinone Noticed that a few commits are duplicated in this PR (the same changes appear multiple times in the commit history). Please consider rebasing or squashing to remove the duplicates for a cleaner history. Also provide commit message. Also your run.sh is not aligned to run in the testkit suite. Refer https://github.com/smuppand/qcom-linux-testkit/blob/lib_changes/CONTRIBUTING.md |
|
Rebasing your branch on top of main will fix the license issue. Last commit (e4bda8ffad71b14d891e46ec38e1985e85883bcb) in your branch is duplicated from main branch and that causes the problem. |
avisinone
force-pushed
the
platform_test
branch
2 times, most recently
from
0cb77ff to
6bbb509
Compare
| update_test_fail(){ | ||
| subtestname=$1 | ||
| msg=$2 | ||
| echo "$subtestname FAIL" >> "$res_file" |
There was a problem hiding this comment.
Can you please only add Over PASS/Fail status. Since this result file is getting parsed to get the test result, it might give wrong status?
There was a problem hiding this comment.
Hi I have changed the result logic. please check
avisinone
force-pushed
the
platform_test
branch
2 times, most recently
from
a5e8847 to
dbc44a0
Compare
| # shellcheck disable=SC1090,SC1091 | ||
| . "$TOOLS/functestlib.sh" | ||
|
|
||
| TESTNAME="systemd" |
There was a problem hiding this comment.
Better to change name of the test. As it is doing for process check here.
|
|
||
| # Call the functions | ||
| check_systemd_pid | ||
| check_systemctl_stop |
There was a problem hiding this comment.
Better move services check to different script. Any reason to club together?
|
|
||
| ANY_SUBTEST_FAILED="false" | ||
|
|
||
| update_test_pass(){ |
There was a problem hiding this comment.
Can be moved to common functions
Updated with suggested changes |
| check_systemctl_stop() { | ||
| log_info "----------------------------------------------------" | ||
| log_info "-------- Starting $TESTNAME Functional Test --------" | ||
| systemctl stop systemd-user-sessions.service |
There was a problem hiding this comment.
before stopping systemctl, can we ensure it is in active state
| log_pass "Able to stop the service systemd-user-sessions with systemctl" | ||
| echo "$TESTNAME PASS" >> "$res_file" | ||
| fi | ||
| log_info "----------------------------------------------------" |
There was a problem hiding this comment.
Also is it required to add cleanup where in you restart the systemctl so that other tests wont get affected?
There was a problem hiding this comment.
changed the test for systemctl start stop into one test to not have redundancy
|
Can you please add readme aswell |
| failed_services=$(systemctl --failed --no-legend --plain | awk '{print $1}') | ||
| if [ -z "$failed_services" ]; then | ||
| log_pass "No service is in failed state on device" | ||
| echo "$TESTNAME PASS" >> "$res_file" |
There was a problem hiding this comment.
Can you please give > instead of >> as this can append the results if new build is not flashed
| log_fail "------ List of failed services --------" | ||
| log_fail "$failed_services" | ||
| log_fail "--------------------------------------" | ||
| echo "$TESTNAME FAIL" >> "$res_file" |
There was a problem hiding this comment.
Can you please give > instead of >> as this can append the results if new build is not flashed
| log_info "-------- Stopping systemd-user-sessions.service --------" | ||
| if ! systemctl is-active --quiet systemd-user-sessions.service; then | ||
| log_info "Service is not active before proceeding with stop command" | ||
| echo "$TESTNAME Fail" >> "$res_file" |
There was a problem hiding this comment.
Can you please give > instead of >> as this can append the results if new build is not flashed
There was a problem hiding this comment.
Same applies to others aswell
There was a problem hiding this comment.
@smuppand Can you please confirm should i change it back to overwriting the result file?
| @@ -0,0 +1,27 @@ | |||
| # systemd Suite | |||
There was a problem hiding this comment.
Please add readme for each test for consistency
avisinone
force-pushed
the
platform_test
branch
2 times, most recently
from
4cdeae7 to
33900ac
Compare
Following check are implemented : systemdPID\run.sh Check systemd starts with PID 1. systemctlStartStop\run.sh Check if systemctl is able to start and stop a service. CheckFailedServices\run.sh Check for failed service on device using systemctl status. Usage Command Verified : ./run-test.sh systemPID ./run-test.sh systemctlStartStop ./run-test.sh CheckFailedServices Signed-off-by: Abhishek Sinha <[email protected]>
|
This pull request has been marked as stale due to 30 days of inactivity. To prevent automatic closure in 7 days, remove the stale label or add a comment. You can reopen a closed pull request at any time. |
|
@avisinone Can you review the errors, resolve them, and upload an updated patch? Please include a more detailed PR description, explaining why this test is necessary and outlining what it will cover. |
4 participants
No description provided.