Skip to content

Conversation

smuppand
Copy link
Contributor

Summary

This PR fixes the shell script executable permissions check in the CI workflow. The previous find command incorrectly matched all files, resulting in false error reports.

Changes

  • Updated the find command in the GitHub Actions workflow to properly group name patterns and ensure only shell scripts missing user-execute permission are flagged.
  • No functional changes to the repo content, only the CI detection logic is corrected.

Impact

This change will:

  • Prevent false CI failures due to incorrect file matching.
  • Ensure only actual permission issues are flagged in PR checks.

No script files were modified. This is a workflow fix for CI reliability.

- Corrected the find command grouping in the permissions workflow to avoid false positives.
- Now, only .sh files (including run.sh) missing user-execute permission are reported.
- Prevents unnecessary errors when all scripts are already executable.

Signed-off-by: Srikanth Muppandam <[email protected]>
@smuppand smuppand requested a review from abbajaj806 June 17, 2025 08:45
Copy link
Contributor

@abbajaj806 abbajaj806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@abbajaj806 abbajaj806 merged commit 4570477 into qualcomm-linux:main Jun 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants