Skip to content

Conversation

smuppand
Copy link
Contributor

This PR improves the rngtest validation script for CI use:

  • Uses dd (not cat) to reliably collect entropy for rngtest input.
  • Adds explicit exit 0/1 codes at every branch to ensure CI reliably detects PASS/FAIL.
  • Handles errors from all random data steps, including drained entropy and missing output.
  • Always cleans up temporary files, regardless of outcome.
  • Adds better debug logs and clarifies error messages for failed tests.
  • Output file naming and parsing is clarified for maintainability.

This ensures CI or manual runs always have robust, predictable results.

- Switch random input collection from cat to dd for reliability.
- Always remove temp files after test run.
- Add consistent exit 0 (PASS) or exit 1 (FAIL) for every outcome.
- Improve error handling on missing dependencies, entropy, and output.
- Log failures for all possible test aborts to aid CI debugging.

Signed-off-by: Srikanth Muppandam <[email protected]>
@smuppand smuppand requested a review from vnarapar June 17, 2025 17:21
Copy link
Contributor

@vnarapar vnarapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smuppand smuppand merged commit 7433bb9 into qualcomm-linux:main Jun 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants