Skip to content

Conversation

Sai-teja573
Copy link
Contributor

This commit introduces the Shmbridge Validation Test, which verifies the presence and initialization of the QCOM_SCM interface on the target device.

Included in this commit:

  • The full test script ("shmbridge") that checks for CONFIG_QCOM_SCM in the kernel config and validates dmesg logs for qcom_scm entries.
  • A comprehensive README.md file with usage instructions, prerequisites, pass/fail criteria, and output format.

This addition enables automated validation of shmbridge functionality as part of the kernel test suite.

@vnarapar vnarapar requested review from smuppand and vnarapar June 20, 2025 10:36
Copy link
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you intend to validate only config checks and dmesg logs for qcom_scm entries, then it's better to write an additional test instead of removing the existing logic using utils.

Copy link
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a few additional minor changes, as well as some clarification regarding the probe failure check.

@Sai-teja573 Sai-teja573 force-pushed the shm_bridge_script branch 5 times, most recently from 212e8aa to 3416581 Compare June 25, 2025 13:00
@smuppand
Copy link
Contributor

@Sai-teja573 - Have there been any decisions about reverting to the original test rather than removing it?

@Sai-teja573
Copy link
Contributor Author

After discussions and confirmation from the TZ tech team, we've decided not to revert to the original test. The current logic is sufficient, as it functions as a complete upstream driver.

vnarapar
vnarapar previously approved these changes Jul 10, 2025
Copy link
Contributor

@vnarapar vnarapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sai-teja573 Sai-teja573 force-pushed the shm_bridge_script branch 2 times, most recently from db41fad to 79d600d Compare July 10, 2025 18:00
@Sai-teja573 Sai-teja573 force-pushed the shm_bridge_script branch 3 times, most recently from f41bdbe to 9bc784a Compare July 14, 2025 10:23
Copy link
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes still required.

Introduced the Shmbridge Validation Test to verify QCOM_SCM support on target devices.

This commit includes:
- A shell script that checks kernel config and dmesg logs for QCOM_SCM presence and probe status.
- A README with usage instructions, prerequisites, and result criteria.

This enhances automated validation of Shmbridge functionality in the kernel test suite.

Signed-off-by: Sai-teja573 <[email protected]>
Copy link

This pull request has been marked as stale due to 30 days of inactivity. To prevent automatic closure in 7 days, remove the stale label or add a comment. You can reopen a closed pull request at any time.

@github-actions github-actions bot added the Stale label Aug 18, 2025
@github-actions github-actions bot closed this Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants