Skip to content

Conversation

Sai-teja573
Copy link
Contributor

This PR introduces a new test script gdsp_remoteproc.sh designed to validate the remoteproc functionality of gpdsp0 and gpdsp1 on the LeMans platform. It also includes a detailed README.md to document the test's purpose, usage, and expected output.

What's Included
1.gdsp_remoteproc.sh: Shell script that Identifies the correct remoteproc entries for gpdsp0 and gpdsp1
2.Verifies initial running state
3.Performs stop and restart operations
4.Confirms successful return to the running state
5. Logs results in a standardized format
6. README.md

Target Platform
LeMans

Notes
This test is specific to LeMans and may require adaptation for other platforms.
Root access is required to control remoteproc state.

Copy link
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains two commits, But they seem closely related. Please squash them into a single, clean commit before merging to keep history concise.

@Sai-teja573 Sai-teja573 force-pushed the gdsp-remoteproc-script branch 5 times, most recently from 0e720e6 to 3c5b373 Compare June 25, 2025 09:27
@Sai-teja573
Copy link
Contributor Author

Merged the changes into a single commit as requested

@Sai-teja573 Sai-teja573 force-pushed the gdsp-remoteproc-script branch 2 times, most recently from 8aef1d7 to 42c3673 Compare June 27, 2025 10:43
@Sai-teja573 Sai-teja573 force-pushed the gdsp-remoteproc-script branch 3 times, most recently from 233209e to 36c8b3b Compare July 11, 2025 09:36
@Sai-teja573 Sai-teja573 force-pushed the gdsp-remoteproc-script branch from 36c8b3b to 1f172ca Compare July 14, 2025 06:54
@vnarapar vnarapar self-requested a review July 14, 2025 07:05
vnarapar
vnarapar previously approved these changes Jul 14, 2025
Copy link
Contributor

@vnarapar vnarapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vnarapar vnarapar requested a review from smuppand July 14, 2025 07:06
Copy link
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In /home/runner/work/qcom-linux-testkit/qcom-linux-testkit/Runner/suites/Kernel/FunctionalArea/baseport/gdsp_remoteproc/run.sh line 74:
result="FAIL"
^----^ SC2034 (warning): result appears unused. Verify use (or export if used externally).

@Sai-teja573
Copy link
Contributor Author

Issue resolved

Copy link
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add debug logs around key steps and also use a consistent results code.

@Sai-teja573 Sai-teja573 force-pushed the gdsp-remoteproc-script branch 3 times, most recently from ccd635b to e766294 Compare July 17, 2025 09:07
This commit introduces a test script to validate gpdsp0 and gpdsp1 remoteproc functionality on the Lemans platform. It includes start/stop/restart checks and logs results in a standardized format. A detailed README is also added to document usage, expected output, and prerequisites.

Signed-off-by: Sai-teja573 <[email protected]>
@Sai-teja573 Sai-teja573 force-pushed the gdsp-remoteproc-script branch from e766294 to f44fded Compare July 18, 2025 05:39
@Sai-teja573 Sai-teja573 requested a review from vnarapar July 18, 2025 06:42
@smuppand
Copy link
Contributor

As part of the code refactoring, we have included the gpdsp test in commit 4cd4c36652ef6c7294ae5661f1d65a9d3df2dd4f, so this PR will be closed.

@smuppand smuppand closed this Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants