Skip to content

Conversation

Sai-teja573
Copy link
Contributor

Refactored remoteproc test scripts for adsp, cdsp, and wpss to use modular helper functions from functestlib.sh.

Changes include:

  • Replaced hardcoded logic with reusable functions: get_remoteproc_path_by_firmware, get_remoteproc_state, stop_remoteproc, and start_remoteproc.
  • Improved readability, maintainability, and consistency across these subsystem tests.

This modularization lays the foundation for extending the same structure to other subsystems like gdsp and general remoteproc validation in future updates.

Copy link
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes are needed to make it more CI-friendly and easier to debug failures.

@Sai-teja573 Sai-teja573 force-pushed the modularize-remoteproc branch from b1cf073 to e41bcfb Compare June 26, 2025 06:29
@Sai-teja573
Copy link
Contributor Author

Added a check to verify if the firmware is loaded when the remoteproc is not running, as suggested.
I'm using dmesg | grep -i "Booting fw image" | grep -i "$name" to confirm firmware load status, which provides better visibility during CI/debugging.

@smuppand smuppand self-requested a review June 26, 2025 10:16
Copy link
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few additional minor changes are still required.

@Sai-teja573 Sai-teja573 force-pushed the modularize-remoteproc branch 2 times, most recently from 39b46f1 to 7713119 Compare June 27, 2025 10:07
@smuppand smuppand self-requested a review June 30, 2025 08:46
Copy link
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor adjustments are needed to ensure better consistency with the logging standards.

@Sai-teja573 Sai-teja573 force-pushed the modularize-remoteproc branch 6 times, most recently from 0313086 to 294a9b9 Compare July 10, 2025 05:38
@Sai-teja573 Sai-teja573 force-pushed the modularize-remoteproc branch 2 times, most recently from 994f626 to 7352b07 Compare July 10, 2025 05:58

return 1
}
=======
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this

@Sai-teja573 Sai-teja573 force-pushed the modularize-remoteproc branch from bb9c639 to 5baf561 Compare July 10, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants