-
Notifications
You must be signed in to change notification settings - Fork 21
Modularized adsp, cdsp, and wpss remoteproc tests using common helper functions #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularized adsp, cdsp, and wpss remoteproc tests using common helper functions #98
Conversation
Runner/suites/Kernel/FunctionalArea/baseport/adsp_remoteproc/run.sh
Outdated
Show resolved
Hide resolved
Runner/suites/Kernel/FunctionalArea/baseport/adsp_remoteproc/run.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes are needed to make it more CI-friendly and easier to debug failures.
b1cf073
to
e41bcfb
Compare
Added a check to verify if the firmware is loaded when the remoteproc is not running, as suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few additional minor changes are still required.
39b46f1
to
7713119
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor adjustments are needed to ensure better consistency with the logging standards.
Runner/suites/Kernel/FunctionalArea/baseport/adsp_remoteproc/run.sh
Outdated
Show resolved
Hide resolved
Runner/suites/Kernel/FunctionalArea/baseport/adsp_remoteproc/run.sh
Outdated
Show resolved
Hide resolved
Runner/suites/Kernel/FunctionalArea/baseport/adsp_remoteproc/run.sh
Outdated
Show resolved
Hide resolved
Runner/suites/Kernel/FunctionalArea/baseport/cdsp_remoteproc/run.sh
Outdated
Show resolved
Hide resolved
Runner/suites/Kernel/FunctionalArea/baseport/wpss_remoteproc/run.sh
Outdated
Show resolved
Hide resolved
Runner/suites/Kernel/FunctionalArea/baseport/cdsp_remoteproc/run.sh
Outdated
Show resolved
Hide resolved
Runner/suites/Kernel/FunctionalArea/baseport/wpss_remoteproc/run.sh
Outdated
Show resolved
Hide resolved
Runner/suites/Kernel/FunctionalArea/baseport/cdsp_remoteproc/run.sh
Outdated
Show resolved
Hide resolved
Runner/suites/Kernel/FunctionalArea/baseport/wpss_remoteproc/run.sh
Outdated
Show resolved
Hide resolved
0313086
to
294a9b9
Compare
994f626
to
7352b07
Compare
Runner/utils/functestlib.sh
Outdated
|
||
return 1 | ||
} | ||
======= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this
bb9c639
to
5baf561
Compare
Refactored remoteproc test scripts for adsp, cdsp, and wpss to use modular helper functions from functestlib.sh.
Changes include:
This modularization lays the foundation for extending the same structure to other subsystems like gdsp and general remoteproc validation in future updates.