Support pathnames in contents.xml #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lool
commented
Sep 11, 2025
lool
commented
- refactor: Avoid repetition of file_name and _path
- feat: Support pathnames in contents.xml
lool
requested review from
lumag,
ndechesne,
sbanerjee-quic and
vkraleti
as code owners
|
This is useful for e.g. Debian images which use ../rootfs.img and similar to share the payloads across boards. |
vkraleti
approved these changes
Sep 11, 2025
|
Missing commit messages. The second one says 'properly', but doesn't define what is proper and what is incorrect currently. |
Commonalize the logic to add XML elements with a file_name and file_path to avoid duplication and to provide a single place for future improvements notably on directory handling. Signed-off-by: Loïc Minier <[email protected]>
Support pathnames (e.g. from partitions.xml) with file and directory
names by splitting them in file_name and file_path respectively, rather
than passing through the full path into file_name and hardcoding the
current directory (".") as file_path.
Signed-off-by: Loïc Minier <[email protected]>
lool
force-pushed
the
contents-xml-directory-name
branch
from
3e37a5b to
a24084a
Compare
Thanks for the review, I've added a commit message where missing and reworded the other one |
vkraleti
approved these changes
Sep 17, 2025
lumag
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.