gen_partition: skip physical_partition with no partition #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gen_partition.py assumes there can be up to 5 LUNs, and generate an XML file with 5 physical_partition entries. For QCS615, there are only 4 LUNs, and we end up generating partitions.xml with an extra, empty physical_partition entry. The right thing would probably be to parse partition.conf and detect how many LUNs we have in there, but a simpler solution is to keep trying 5 LUNs but only create the physical_partition entry once we find at least one partition, which is what this patch does. It should fix the problem we've noticed in qualcomm-linux#42. Signed-off-by: Nicolas Dechesne <[email protected]>
ndechesne
requested review from
lumag,
sbanerjee-quic and
vkraleti
as code owners
lumag
requested changes
Oct 3, 2025
vkraleti
approved these changes
Oct 7, 2025
vkraleti
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gen_partition.py assumes there can be up to 5 LUNs, and generate an XML file with 5 physical_partition entries. For QCS615, there are only 4 LUNs, and we end up generating partitions.xml with an extra, empty physical_partition entry.
The right thing would probably be to parse partition.conf and detect how many LUNs we have in there, but a simpler solution is to keep trying 5 LUNs but only create the physical_partition entry once we find at least one partition, which is what this patch does. It should fix the problem we've noticed in #42.