-
Notifications
You must be signed in to change notification settings - Fork 14
qrb2210-rb1: increase HYP partition size #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The commit says 'at least 2MB', did you mean 'a maximum of' 2MB? This is "breaking" existing user since it's moving all partitions. @lool, FYI. |
Yeah on other QLI platforms like KLMT, we are reserving 8MB for HYP image but I just wanted to reserve 2MB since I got to know that the Gunyah image size is approx 1.4 MB as of now. I can do a 8MB as a maximum reserve if you like to be aligned with other KLMT platforms.
I am not sure how this would be a breaking change since from software perspective the number of partitions or partition indexes remains the same. Can you elaborate a bit further? |
I think we need to be consistent across platforms; if we're expecting boot firmware to carry similar features across platforms, then the size budget ought to be similar, right? Right now, we have these:
So essentially older platforms have 512KiB – one or two partitions – and newer platforms have either 8MiBx2 or 64MiBx2. Could we capture this in the form of a test? Perhaps something like: if you're tracking this kind of firmware, then we expect you to have a minimum size of X for this and that partition. Should we immediately send a patch for Imola? There might be still time to change factory image. Going from 512KiB to 2 or even 8MiB x2 (which would be the most consistent IMO) is another 15MiB hit on that constrained storage, but I think it's the right thing to do. |
Sounds fair but I was atleast expecting a reason for current boot firmware partition size allocation such that we are making an informed decision here. However, I can change the patch to allocate 8MB for HYP image instead.
I don't have information as to where these partition size allocation requirements come from, will try to reach out to the boot teams.
I would avoid that as of now since the teams are working on QLI firmware for Agatti and it is possible they may require more changes as we go further. However, for UNO-Q I suppose Arduino will just publish new firmware with steps to reflash with QDL for which it is rather better to do corresponding partition changes needed at once. |
For QLI mainline firmware support, Gunyah requires at maximum 8MB HYP image partition size. Let's update HYP partition size to support that. Signed-off-by: Sumit Garg <[email protected]>
Updated HYP partition size to 8MB. |
For QLI mainline firmware support, Gunyah requires at maximum 8MB HYP image partition size. Let's update HYP partition size to support that.