feat: add Dockerfile-based action for artifact uploads to s3#15
Merged
doanac merged 1 commit intoqualcomm-linux:awsfrom Feb 18, 2026
Merged
feat: add Dockerfile-based action for artifact uploads to s3#15doanac merged 1 commit intoqualcomm-linux:awsfrom
doanac merged 1 commit intoqualcomm-linux:awsfrom
Conversation
fddbf2f to
86c2ddf
Compare
doanac
reviewed
Feb 18, 2026
Dockerfile
Outdated
| fi && \ | ||
| unzip awscliv2.zip && \ | ||
| ./aws/install && \ | ||
| rm -rf aws awscliv2.zip |
Contributor
There was a problem hiding this comment.
alpine linux doesn't use the "apt" installer. you just need:
FROM public.ecr.aws/docker/library/alpine:3.21
RUN apk add aws-cli
That does what lines 1-19 are currently doing
Author
There was a problem hiding this comment.
will it also handle the Arch?
Contributor
There was a problem hiding this comment.
yes - but please test and make sure
73ef0fc to
6176b6f
Compare
doanac
reviewed
Feb 18, 2026
Dockerfile
Outdated
|
|
||
| # Copy entrypoint script into the container | ||
| COPY publish_artifacts.sh / | ||
| RUN chmod +x /publish_artifacts.sh |
Contributor
There was a problem hiding this comment.
You can make this:
COPY --chmod=0755 publish_artifacts.sh /
and remove one layer from the container.
- Introduce Dockerfile using alpine linux from public ECR - Preinstall AWS CLI - Add entrypoint script (publish_artifacts.sh) to check AWS credentials and upload artifacts - Configure action.yml to run with Docker image instead of composite steps Signed-off-by: Vishal Kumar <viskuma@qti.qualcomm.com>
doanac
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.