Main setsymboladdress only (alternate to PR 1749) - #1751
Merged
Shankar Easwaran (quic-seaswara) merged 2 commits intoAug 28, 2026
Merged
Conversation
Troy Curtiss (tcurtiss)
requested a review
from Shankar Easwaran (quic-seaswara)
as a code owner
August 22, 2026 00:01
Shankar Easwaran (quic-seaswara)
requested changes
Aug 25, 2026
Shankar Easwaran (quic-seaswara)
requested review from
Parth (parth-07) and
quic-areg
August 25, 2026 21:27
Troy Curtiss (tcurtiss)
requested a review
from Shankar Easwaran (quic-seaswara)
August 26, 2026 07:30
Troy Curtiss (tcurtiss)
requested a review
from Shankar Easwaran (quic-seaswara)
August 26, 2026 21:45
Shankar Easwaran (quic-seaswara)
approved these changes
Aug 26, 2026
- LinkerWrapper::setSymbolAddress(Symbol, Addr): detaches a defined symbol from its fragment and assigns it an absolute (SHN_ABS) value, callable during AfterLayout. Limited to data symbols only and ensure address range is within that of the target architecture. Annotation is shown in the map file for affected symbols. Signed-off-by: Troy Curtiss <trcurtiss@gmail.com>
Troy Curtiss (tcurtiss)
force-pushed
the
main_setsymboladdress_only
branch
from
August 27, 2026 02:24
14a4af9 to
3aed704
Compare
- LinkerWrapper::setSymbolAddress(Symbol, Addr): detaches a defined symbol from its fragment and assigns it an absolute (SHN_ABS) value, callable during AfterLayout. Limited to data symbols only and ensure address range is within that of the target architecture. Annotation is shown in the map file for affected symbols. Signed-off-by: Troy Curtiss <trcurtiss@gmail.com>
Parth (parth-07)
approved these changes
Aug 28, 2026
Parth (parth-07)
left a comment
Parth (parth-07)
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me!
Shankar Easwaran (quic-seaswara)
merged commit Aug 28, 2026
70ad171
into
qualcomm:main
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use this PR if the setExcludeFromOverlapCheck and setAllowedInNonLoadSegment plugin APIs in PR 1749 are not needed.
LinkerWrapper::setSymbolAddress(Symbol, Addr): detaches a defined symbol from its fragment and assigns it an absolute (SHN_ABS) value, callable during AfterLayout. Preserves original binding (e.g. global, local, weak)