Move -ldl -lm and $(USE_LOG) from LDFLAGS to *_LIBADD#288
Merged
ekanshibu merged 1 commit intoqualcomm:developmentfrom Feb 3, 2026
Merged
Move -ldl -lm and $(USE_LOG) from LDFLAGS to *_LIBADD#288ekanshibu merged 1 commit intoqualcomm:developmentfrom
ekanshibu merged 1 commit intoqualcomm:developmentfrom
Conversation
Autotools expects library dependencies to be specified via *_LIBADD,
not LDFLAGS. Placing -ldl -lm and $(USE_LOG) in *_LIBADD ensures
libtool orders them after objects and before dependent libs, and
prevents it from treating dependent libs as linker flags.
This fixes a non-Android link failure on aarch64 where libtool tried
to load a .la for BSD and errored with:
libtool: error: '/usr/aarch64-linux-gnu/lib/libbsd.la' is not a
valid libtool archive
By moving these flags into lib{adsp,cdsp,sdsp,gdsp}rpc_la_LIBADD and
keeping LDFLAGS limited to versioning, the link completes cleanly
across targets.
Signed-off-by: Abhinav Parihar <parihar@qti.qualcomm.com>
quic-vkatoch
approved these changes
Feb 2, 2026
ekanshibu
approved these changes
Feb 3, 2026
Chennak-quic
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autotools expects library dependencies to be specified via *_LIBADD, not LDFLAGS. Placing -ldl -lm and $(USE_LOG) in *_LIBADD ensures libtool orders them after objects and before dependent libs, and prevents it from treating dependent libs as linker flags.
This fixes a non-Android link failure on aarch64 where libtool tried to load a .la for BSD and errored with:
libtool: error: '/usr/aarch64-linux-gnu/lib/libbsd.la' is not a valid libtool archive
By moving these flags into lib{adsp,cdsp,sdsp,gdsp}rpc_la_LIBADD and keeping LDFLAGS limited to versioning, the link completes cleanly across targets.