wdfserial: fix diag port re-enumeration by clearing DeviceRemoveEvent, incrementing QCDeviceGeneration, and refreshing ReportDeviceName on D0Entry - #103
Merged
Chenxi Han (5656hcx) merged 1 commit intoAug 18, 2026
Conversation
…, incrementing QCDeviceGeneration, and refreshing ReportDeviceName on D0Entry Signed-off-by: rohimish <rohimish@qti.qualcomm.com>
Rohit Mishra (rohimish-qc)
requested review from
Chenxi Han (5656hcx),
hangzqcom,
Shashank Arora (shasaror) and
Tejas Sharma (tejas-sharma27)
August 17, 2026 10:19
Chenxi Han (5656hcx)
approved these changes
Aug 18, 2026
Contributor
|
Merged. |
hangzqcom
reviewed
Aug 19, 2026
| // EvtDeviceAdd fires only once; D0Entry fires on each re-enumeration. | ||
| if (pDevContext->FdoDeviceType == FILE_DEVICE_SERIAL_PORT) | ||
| { | ||
| QCPNP_ReportDeviceName(pDevContext); |
Contributor
There was a problem hiding this comment.
After this fix, every time a Hawi diag port wakes from idle/selective-suspend, the driver will re-send its device name to the parent filter driver, not just on true re-enumeration. That's extra IOCTL traffic to the filter driver on a cadence that could be quite frequent (every idle-in/idle-out cycle), for zero benefit in the non-re-enum case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
exiting immediately on re-enumeration due to a stale removal signal
device re-enumeration even when DevDesc/DevName/SerNum are identical across reboots
parent filter driver on every re-enumeration, not just on first add
Fixes #
Type of Change
release/x.ybranch)How has this been tested?
Checklist
<branch-prefix>/<area>/<description>feature/bugfix/hotfix/docs)develop(orrelease/x.yfor hotfix) - no merge commitsSigned-off-by:(DCO) - see CONTRIBUTING.mdFixes #...)