Skip to content

Add support of Maker rebate activity type#41

Merged
qualiaenjoyer merged 6 commits intoqualiaenjoyer:mainfrom
codez0mb1e:maker-rebate-activity
Mar 6, 2026
Merged

Add support of Maker rebate activity type#41
qualiaenjoyer merged 6 commits intoqualiaenjoyer:mainfrom
codez0mb1e:maker-rebate-activity

Conversation

@codez0mb1e
Copy link
Contributor

Changelog:

Copilot AI review requested due to automatic review settings March 6, 2026 13:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a ValidationError that occurred when the Polymarket API returned activities with a MAKER_REBATE type, which was not included in the Activity model's type literal. It also introduces a reusable ActivityType alias to eliminate duplication of the literal values.

Changes:

  • Added MAKER_REBATE to the accepted activity types and created an ActivityType type alias to centralize the literal definition
  • Replaced the duplicated inline Literal[...] in get_activity()'s type parameter with the new ActivityType alias
  • Bumped package version from 0.5.0 to 0.5.1

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/polymarket_apis/types/data_types.py Introduced ActivityType alias with MAKER_REBATE added, and used it in the Activity model
src/polymarket_apis/types/__init__.py Exported ActivityType in imports and __all__
src/polymarket_apis/clients/data_client.py Imported ActivityType and replaced inline literal duplication in get_activity()
pyproject.toml Version bump from 0.5.0 to 0.5.1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@qualiaenjoyer qualiaenjoyer merged commit fce449a into qualiaenjoyer:main Mar 6, 2026
1 check passed
@codez0mb1e codez0mb1e deleted the maker-rebate-activity branch March 11, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activity model missing MAKER_REBATE type from Polymarket API

3 participants