Add support of Maker rebate activity type#41
Merged
qualiaenjoyer merged 6 commits intoqualiaenjoyer:mainfrom Mar 6, 2026
Merged
Add support of Maker rebate activity type#41qualiaenjoyer merged 6 commits intoqualiaenjoyer:mainfrom
qualiaenjoyer merged 6 commits intoqualiaenjoyer:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a ValidationError that occurred when the Polymarket API returned activities with a MAKER_REBATE type, which was not included in the Activity model's type literal. It also introduces a reusable ActivityType alias to eliminate duplication of the literal values.
Changes:
- Added
MAKER_REBATEto the accepted activity types and created anActivityTypetype alias to centralize the literal definition - Replaced the duplicated inline
Literal[...]inget_activity()'stypeparameter with the newActivityTypealias - Bumped package version from
0.5.0to0.5.1
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/polymarket_apis/types/data_types.py |
Introduced ActivityType alias with MAKER_REBATE added, and used it in the Activity model |
src/polymarket_apis/types/__init__.py |
Exported ActivityType in imports and __all__ |
src/polymarket_apis/clients/data_client.py |
Imported ActivityType and replaced inline literal duplication in get_activity() |
pyproject.toml |
Version bump from 0.5.0 to 0.5.1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog:
Activitymodel missingMAKER_REBATEtype from Polymarket API #40ActivityTypealias to avoid copy-paste of literals.