Fix Makefile object names for targets: gfortran, intel-seq#65
Open
chstan wants to merge 1 commit intoquanshengwu:masterfrom
Open
Fix Makefile object names for targets: gfortran, intel-seq#65chstan wants to merge 1 commit intoquanshengwu:masterfrom
chstan wants to merge 1 commit intoquanshengwu:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 31.72% 31.72%
=======================================
Files 36 36
Lines 13777 13777
=======================================
Hits 4371 4371
Misses 9406 9406Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In compiling (initially for Windows and subsequently for Ubuntu with the gfortran toolchain) I ran into this issue where compilation fails because
makeis treating the targets in a case sensitive way.I've updated the Makefiles for all targets so they refer to the $(OBJ) with the same case (all caps) as the designated target.
For others in the future, this manifested as an error in the linker because no object files were being built:
gfortran in function _start' (.text+0x20) undefined reference to main'