Skip to content

feat(sessions): add session_id FK to link agent_sessions to session logs (Phase 1 of #1668) #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OAGr wants to merge 5 commits into
base: main
Choose a base branch
from
+189 −22
Open

feat(sessions): add session_id FK to link agent_sessions to session logs (Phase 1 of #1668) #1812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
89a36e8
feat(sessions): add session_id FK to link agent_sessions to session logs
OAGr Mar 6, 2026
aef12cf
fix(ci): exclude adding-foreign-key-constraint squawk rule
OAGr Mar 6, 2026
e800b18
fix: rebase onto main + address CodeRabbit review feedback
OAGr Mar 7, 2026
4f53fed
feat(pr-patrol): resolve CodeRabbit threads after successful fix
OAGr Mar 7, 2026
b501f76
fix(agent-sessions): enforce FK in test mock, fix DrizzleQueryError c…
OAGr Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .squawk.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,13 @@ pg_version = "16"
# by ensuring migrations only run once.
#
# require-concurrent-index-creation, disallowed-unique-constraint, constraint-missing-not-valid,
# adding-not-nullable-field:
# adding-not-nullable-field, adding-foreign-key-constraint:
# Drizzle's migrator runs ALL statements in a single transaction (see pg-core/dialect.js
# line 60). CREATE INDEX CONCURRENTLY cannot run inside a transaction, so these online-safe
# patterns are impossible with Drizzle. Tables are small (~700 rows) so brief locking is
# acceptable. If large-table migrations are needed in the future, use a separate raw SQL
# runner outside Drizzle.
# line 60). CREATE INDEX CONCURRENTLY cannot run inside a transaction, and the NOT VALID
# two-step pattern for FK constraints requires two separate transactions — both impossible
# with Drizzle. Tables are small (hundreds of rows) so brief locking is acceptable.
# If large-table migrations are needed in the future, use a separate raw SQL runner
# outside Drizzle (see .claude/rules/database-migrations.md for the manual migration pattern).
excluded_rules = [
"prefer-bigint-over-int",
"prefer-identity",
Expand All @@ -38,4 +39,5 @@ excluded_rules = [
"disallowed-unique-constraint",
"constraint-missing-not-valid",
"adding-not-nullable-field",
"adding-foreign-key-constraint",
]
13 changes: 10 additions & 3 deletions apps/web/src/app/internal/agent-sessions/agent-sessions-content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,18 +49,25 @@ async function loadFromApi(): Promise<FetchResult<AgentSessionRow[]>> {
revalidate: 60,
});

// Build a branch → session log map for enrichment
// Build lookup maps for enrichment:
// 1. session_id → session log (direct FK, preferred for newer records)
// 2. branch → session log (fallback heuristic for older records without session_id)
const logsById = new Map<number, SessionRow>();
const logsByBranch = new Map<string, SessionRow>();
if (logsResult.ok) {
for (const log of logsResult.data.items) {
logsById.set(log.id, log);
if (log.branch) {
logsByBranch.set(log.branch, log);
}
}
}

const rows: AgentSessionRow[] = agentResult.data.sessions.map((s): AgentSessionRow => {
const log = logsByBranch.get(s.branch);
// Prefer FK-linked session log; only fall back to branch heuristic when sessionId is absent
const log = s.sessionId != null
? logsById.get(s.sessionId)
: logsByBranch.get(s.branch);
return {
id: s.id,
branch: s.branch,
Expand All @@ -72,7 +79,7 @@ async function loadFromApi(): Promise<FetchResult<AgentSessionRow[]>> {
startedAt: s.startedAt,
completedAt: s.completedAt,
// Prefer prUrl from agent_sessions (set by `crux issues done --pr=URL`),
// fall back to session log join on branch for older records.
// fall back to session log for older records.
prUrl: s.prUrl ?? log?.prUrl ?? null,
prOutcome: s.prOutcome ?? null,
fixesPrUrl: s.fixesPrUrl ?? null,
Expand Down
20 changes: 20 additions & 0 deletions apps/wiki-server/drizzle/0063_add_session_id_to_agent_sessions.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
-- Add session_id FK to agent_sessions, linking live tracking records to their
-- corresponding historical session log.
--
-- This replaces the fragile branch-name join currently used by the Agent Sessions
-- dashboard to enrich agent_sessions with cost/model data from the sessions table.
-- With this FK, the dashboard can use a direct JOIN instead of a heuristic match.
--
-- The column is nullable because:
-- 1. Older records predate this migration and won't have a session_id
-- 2. Some agent sessions may never produce a session log (e.g., abandoned sessions)
-- 3. Session logs can be created after agent sessions (at PR time)
--
-- Note: adding-foreign-key-constraint is excluded in .squawk.toml because Drizzle's
-- migrator runs in a single transaction, making the two-step NOT VALID / VALIDATE
-- pattern impossible. agent_sessions is a small table (hundreds of rows), so the
-- brief SHARE ROW EXCLUSIVE lock is acceptable.

ALTER TABLE "agent_sessions" ADD COLUMN IF NOT EXISTS "session_id" bigint REFERENCES "sessions"("id") ON DELETE SET NULL;

CREATE INDEX IF NOT EXISTS "idx_as_session_id" ON "agent_sessions" ("session_id");
7 changes: 7 additions & 0 deletions apps/wiki-server/drizzle/meta/_journal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,13 @@
"when": 1773993600000,
"tag": "0062_add_numeric_cost_duration_to_sessions",
"breakpoints": true
},
{
"idx": 63,
"version": "7",
"when": 1774080000000,
"tag": "0063_add_session_id_to_agent_sessions",
"breakpoints": true
}
]
}
73 changes: 73 additions & 0 deletions apps/wiki-server/src/__tests__/agent-sessions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ import {
postJson,
} from "./test-utils";

// ---- In-memory sessions fixture (simulates FK target) ----
// Pre-seeded IDs that are valid FK targets for session_id.
// Tests that use sessionId: 42 must find it here; others must not.
const VALID_SESSION_IDS = new Set<number>([42]);

// ---- In-memory store simulating agent_sessions table ----

let nextId = 1;
Expand All @@ -16,6 +21,7 @@ let store: Array<{
session_type: string;
issue_number: number | null;
checklist_md: string;
session_id: number | null;
status: string;
started_at: Date;
completed_at: Date | null;
Expand Down Expand Up @@ -48,6 +54,7 @@ const dispatch: SqlDispatcher = (query, params) => {
session_type: params[2] as string,
issue_number: params[3] as number | null,
checklist_md: params[4] as string,
session_id: null,
status: "active",
started_at: new Date(),
completed_at: null,
Expand Down Expand Up @@ -88,6 +95,17 @@ const dispatch: SqlDispatcher = (query, params) => {
case "checklist_md":
store[idx].checklist_md = params[pIdx] as string;
break;
case "session_id": {
const sid = params[pIdx] as number | null;
if (sid !== null && !VALID_SESSION_IDS.has(sid)) {
// Simulate FK constraint violation — the route translates this to 400.
throw new Error(
`insert or update on table "agent_sessions" violates foreign key constraint`
);
}
store[idx].session_id = sid;
break;
}
case "status":
store[idx].status = params[pIdx] as string;
break;
Expand Down Expand Up @@ -486,6 +504,61 @@ describe("Agent Sessions API", () => {
});
expect(res.status).toBe(400);
});

it("sets sessionId FK link to session log", async () => {
await postJson(app, "/api/agent-sessions", sampleSession);

const res = await patchJson(app, "/api/agent-sessions/1", {
sessionId: 42,
});
expect(res.status).toBe(200);
const body = await res.json();
expect(body.sessionId).toBe(42);
});

it("clears sessionId with null", async () => {
await postJson(app, "/api/agent-sessions", sampleSession);

// Set it first
await patchJson(app, "/api/agent-sessions/1", { sessionId: 42 });

// Now clear it
const res = await patchJson(app, "/api/agent-sessions/1", {
sessionId: null,
});
expect(res.status).toBe(200);
const body = await res.json();
expect(body.sessionId).toBeNull();
});

it("rejects non-integer sessionId", async () => {
await postJson(app, "/api/agent-sessions", sampleSession);

const res = await patchJson(app, "/api/agent-sessions/1", {
sessionId: 1.5,
});
expect(res.status).toBe(400);
});

it("rejects zero sessionId", async () => {
await postJson(app, "/api/agent-sessions", sampleSession);

const res = await patchJson(app, "/api/agent-sessions/1", {
sessionId: 0,
});
expect(res.status).toBe(400);
});

it("returns 400 invalid_reference for non-existent sessionId", async () => {
await postJson(app, "/api/agent-sessions", sampleSession);

const res = await patchJson(app, "/api/agent-sessions/1", {
sessionId: 9999, // not in VALID_SESSION_IDS — FK violation
});
expect(res.status).toBe(400);
const body = await res.json();
expect(body.error).toBe("invalid_reference");
});
});

// ================================================================
Expand Down
2 changes: 2 additions & 0 deletions apps/wiki-server/src/api-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1174,6 +1174,8 @@ export const UpdateAgentSessionSchema = z.object({
prUrl: z.string().url().max(1000).nullable().optional(),
prOutcome: z.enum(PR_OUTCOMES).nullable().optional(),
fixesPrUrl: z.string().url().max(1000).nullable().optional(),
/** FK to the sessions table — set when the session log is synced to the DB */
sessionId: z.number().int().positive().nullable().optional(),
});
export type UpdateAgentSession = z.infer<typeof UpdateAgentSessionSchema>;

Expand Down
38 changes: 30 additions & 8 deletions apps/wiki-server/src/routes/agent-sessions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,15 +115,16 @@ const agentSessionsApp = new Hono()
const parsed = UpdateAgentSessionSchema.safeParse(body);
if (!parsed.success) return validationError(c, parsed.error.message);

const { checklistMd, status, prUrl, prOutcome, fixesPrUrl } = parsed.data;
const { checklistMd, status, prUrl, prOutcome, fixesPrUrl, sessionId } = parsed.data;
if (
checklistMd === undefined &&
status === undefined &&
prUrl === undefined &&
prOutcome === undefined &&
fixesPrUrl === undefined
fixesPrUrl === undefined &&
sessionId === undefined
) {
return validationError(c, "At least one of checklistMd, status, prUrl, prOutcome, or fixesPrUrl must be provided");
return validationError(c, "At least one of checklistMd, status, prUrl, prOutcome, fixesPrUrl, or sessionId must be provided");
}

const updates: Record<string, unknown> = { updatedAt: new Date() };
Expand All @@ -137,13 +138,34 @@ const agentSessionsApp = new Hono()
if (prUrl !== undefined) updates.prUrl = prUrl;
if (prOutcome !== undefined) updates.prOutcome = prOutcome;
if (fixesPrUrl !== undefined) updates.fixesPrUrl = fixesPrUrl;
if (sessionId !== undefined) updates.sessionId = sessionId;

const db = getDrizzleDb();
const result = await db
.update(agentSessions)
.set(updates)
.where(eq(agentSessions.id, id))
.returning();
let result;
try {
result = await db
.update(agentSessions)
.set(updates)
.where(eq(agentSessions.id, id))
.returning();
} catch (e: unknown) {
// Drizzle wraps DB errors in DrizzleQueryError; the FK message lives in e.cause.
const msg = e instanceof Error ? e.message : String(e);
const causeMsg =
e instanceof Error && e.cause instanceof Error ? e.cause.message : "";
const isFkViolation =
msg.includes("foreign key") ||
msg.includes("violates foreign key") ||
causeMsg.includes("foreign key") ||
causeMsg.includes("violates foreign key");
if (isFkViolation) {
return c.json(
{ error: "invalid_reference", message: "sessionId references a non-existent session" },
400,
);
}
Comment on lines +145 to +166
Copy link

@coderabbitai coderabbitai bot Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '\n== apps/wiki-server/src/db.ts ==\n'
sed -n '1,220p' apps/wiki-server/src/db.ts

printf '\n== DB-related dependencies ==\n'
fd 'package\.json$' . -x sh -c '
  jq -r "
    ((.dependencies // {}) + (.devDependencies // {}))
    | to_entries[]
    | select(.key | test(\"drizzle|pg|postgres|neon\"))
    | \"\(.key)@\(.value)\"
  " "$1"
' sh {}

printf '\n== Existing database error handling ==\n'
rg -n '23503|PostgresError|DatabaseError|foreign key' apps/wiki-server/src crux

Repository: quantified-uncertainty/longterm-wiki

Length of output: 12038

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '\n== Package.json dependencies (wiki-server) ==\n'
cat apps/wiki-server/package.json | jq '.dependencies + .devDependencies | with_entries(select(.key | test("drizzle|pg|postgres|neon")))' 2>/dev/null || echo "Failed to parse, trying alternative"

printf '\n== Direct grep for dependencies ==\n'
grep -E '"(drizzle|pg|postgres|neon)' apps/wiki-server/package.json || echo "No matches"

printf '\n== Search for error handling patterns ==\n'
rg -n 'code|SQLSTATE|23503' apps/wiki-server/src --type ts -A 2 -B 2 | head -100

printf '\n== Search for foreign key error handling ==\n'
rg -n 'foreign key|fk_violation|FK' apps/wiki-server/src --type ts -A 3 -B 1 | head -100

printf '\n== Check postgres-js error types if available ==\n'
rg -n 'postgres.*Error|PostgresError|throw.*Error' apps/wiki-server/src --type ts | head -50

Repository: quantified-uncertainty/longterm-wiki

Length of output: 16787

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '\n== Test for FK violation in agent-sessions ==\n'
grep -A 20 'FK\|foreign key\|violates' apps/wiki-server/src/__tests__/agent-sessions.test.ts | head -80

printf '\n== Full statements.ts error handling pattern ==\n'
sed -n '1390,1410p' apps/wiki-server/src/routes/statements.ts

printf '\n== Search for postgres-js usage with error code ==\n'
rg -n "\.code\s*===" apps/wiki-server/src --type ts -B 2 -A 2

printf '\n== Check for SQLSTATE or error code constants ==\n'
rg -n "23503|SQLSTATE" apps/wiki-server --type ts -B 1 -A 1

Repository: quantified-uncertainty/longterm-wiki

Length of output: 1767

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '\n== Search for postgres error codes used anywhere ==\n'
rg -n "code.*23" apps/wiki-server --type ts

printf '\n== Check node_modules postgres-js for error types ==\n'
find node_modules/postgres -name "*.d.ts" 2>/dev/null | head -5 | xargs head -100

printf '\n== Look for FK violation test patterns ==\n'
rg -n "invalid_reference|sessionId.*42" apps/wiki-server/src/__tests__ --type ts -B 5 -A 10 | head -150

printf '\n== Look at the entire agent-sessions PATCH test suite ==\n'
sed -n '490,520p' apps/wiki-server/src/__tests__/agent-sessions.test.ts

Repository: quantified-uncertainty/longterm-wiki

Length of output: 477

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '\n== Migration defining the FK ==\n'
cat apps/wiki-server/drizzle/0063_add_session_id_to_agent_sessions.sql

printf '\n== Integration test for agent-sessions ==\n'
rg -n "sessionId" apps/wiki-server/src/__tests__/integration.test.ts -B 3 -A 8 | head -100

printf '\n== Check if there's a test that tests FK error specifically ==\n'
rg -n "invalid_reference\|400.*sessionId\|FK.*error" apps/wiki-server/src/__tests__ --type ts

Repository: quantified-uncertainty/longterm-wiki

Length of output: 1299

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '\n== Check agent-sessions route for the full error handling ==\n'
sed -n '140,165p' apps/wiki-server/src/routes/agent-sessions.ts

printf '\n== Look for any test that expects 400 invalid_reference ==\n'
rg -n "invalid_reference" apps/wiki-server/src --type ts -B 3 -A 3

printf '\n== Check postgres-js README or docs reference ==\n'
find . -name "README*" -o -name "CHANGELOG*" 2>/dev/null | xargs grep -l "postgres" 2>/dev/null | head -3

printf '\n== Search for error.code usage patterns ==\n'
rg -n "error\.code|err\.code" apps/wiki-server/src --type ts -B 2 -A 2 | head -60

Repository: quantified-uncertainty/longterm-wiki

Length of output: 1801

🌐 Web query:

postgres-js error handling SQLSTATE code property

💡 Result:

In postgres-js (the postgres / Postgres.js library), PostgreSQL server errors are thrown as a PostgresError where the SQLSTATE is available on:

  • error.code → the 5-character PostgreSQL SQLSTATE (e.g. 23505 for unique violation). [1]

Example:

import postgres from 'postgres'
const sql = postgres()

try {
  await sql`insert into users(email) values (${email})`
} catch (err) {
  if (err.code === '23505') {
    // UNIQUE_VIOLATION
  }
  // other useful fields (when present): err.detail, err.hint, err.constraint_name, etc.
}

Notes:

  • Postgres.js also uses code for some client/connection errors, but those may be non-SQLSTATE strings like UNDEFINED_VALUE, CONNECT_TIMEOUT, etc. [1]
  • SQLSTATE codes are standardized 5-character codes; PostgreSQL documents them and recommends checking the code instead of parsing text messages. [2]

Sources:
[1] Postgres.js error handling docs (PostgresError fields incl. code as SQLSTATE) (tessl.io)
[2] PostgreSQL error codes (SQLSTATE) documentation (postgresql.org)

Citations:

🌐 Web query:

PostgreSQL SQLSTATE 23503 foreign key violation

💡 Result:

SQLSTATE 23503 in PostgreSQL means foreign_key_violation: a statement would break a FOREIGN KEY constraint. [1]

It typically happens in two cases:

  1. INSERT/UPDATE on the child (referencing) table: you set a foreign-key column to a value that doesn’t exist in the parent (referenced) table (often shown as DETAIL: Key (...)=(...) is not present in table ...). [2]
  2. DELETE/UPDATE on the parent table: you try to delete/update a parent row that’s still referenced by rows in a child table (behavior depends on ON DELETE/ON UPDATE action like RESTRICT/NO ACTION/CASCADE/SET NULL/SET DEFAULT). [2]

How to fix

  • Ensure the parent row exists first (insert parent, then child), or change the FK value to an existing parent key. [2]
  • If you’re deleting/updating a parent row, choose the right referential action:
    • ON DELETE CASCADE (delete children automatically),
    • ON DELETE SET NULL/SET DEFAULT,
    • or keep RESTRICT/NO ACTION and delete/update children explicitly first. [2]
  • If the order of operations is the issue within a transaction, consider a DEFERRABLE FK and defer checking until commit (e.g., SET CONSTRAINTS ... DEFERRED). [2]

Quick diagnosis tip: the error message includes the constraint name (e.g., ... violates foreign key constraint "child_parent_id_fkey"). Use that to find the exact FK definition in your schema.

Sources: PostgreSQL error code 23503 = foreign_key_violation [1]; PostgreSQL docs on foreign keys and referential actions (and deferrable checking) [2].

[1] PostgreSQL Documentation: “PostgreSQL Error Codes” (SQLSTATE 23503)
[2] PostgreSQL Documentation: “Constraints” (Foreign keys, ON DELETE/ON UPDATE, deferrable checking)

Use error.code === "23503" instead of parsing error.message for FK violations.

The postgres library exposes PostgreSQL error codes on error.code (the 5-character SQLSTATE). For foreign key violations, this is "23503". The current string-matching approach is fragile and may fail if the error message shape changes; this codebase already uses the .code property pattern in statements.ts (lines 1397–1404).

Replace the message check:

if (msg.includes("foreign key") || msg.includes("violates foreign key"))

with:

if ((e as { code?: string }).code === "23503")
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@apps/wiki-server/src/routes/agent-sessions.ts` around lines 145 - 156, The
catch block around the db.update(...).returning() currently inspects the error
message string to detect a foreign key violation; update it to check the
PostgreSQL SQLSTATE code instead by testing the caught error object (e) for a
code property equal to "23503" (e.g., use a type guard like (e as { code?:
string }).code === "23503") and keep the same response for that case; ensure you
still derive msg for other logging/handling but stop using msg.includes("foreign
key") or similar string checks.

throw e;
}

if (result.length === 0) {
return c.json({ error: "not_found", message: `No session with id: ${id}` }, 404);
Expand Down
2 changes: 2 additions & 0 deletions apps/wiki-server/src/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,6 +762,7 @@ export const agentSessions = pgTable(
prUrl: text("pr_url"), // PR URL recorded when crux issues done --pr=URL is called
prOutcome: text("pr_outcome"), // Outcome: merged | merged_with_revisions | reverted | closed_without_merge
fixesPrUrl: text("fixes_pr_url"), // URL of the PR this session is fixing (enables fix-chain tracking)
sessionId: bigint("session_id", { mode: "number" }).references(() => sessions.id, { onDelete: "set null" }), // FK to session log — set when session completes and log is synced
status: text("status").notNull().default("active"),
startedAt: timestamp("started_at", { withTimezone: true })
.notNull()
Expand All @@ -779,6 +780,7 @@ export const agentSessions = pgTable(
index("idx_as_status").on(table.status),
index("idx_as_issue").on(table.issueNumber),
index("idx_as_started_at").on(table.startedAt),
index("idx_as_session_id").on(table.sessionId),
]
);

Expand Down
14 changes: 12 additions & 2 deletions crux/pr-patrol/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export type PrIssueType =
| 'bot-review-nitpick';

interface BotComment {
threadId: string;
path: string;
line: number | null;
startLine: number | null;
Expand Down Expand Up @@ -614,7 +615,7 @@ const PR_QUERY = `query($owner: String!, $name: String!) {
}}
}}}}
reviewThreads(first: 50) { nodes {
isResolved isOutdated path line startLine
id isResolved isOutdated path line startLine
comments(first: 3) { nodes {
author { login }
body
Expand All @@ -626,6 +627,7 @@ const PR_QUERY = `query($owner: String!, $name: String!) {
}`;

interface GqlReviewThread {
id: string;
isResolved: boolean;
isOutdated: boolean;
path: string;
Expand Down Expand Up @@ -684,6 +686,7 @@ function extractBotComments(pr: GqlPrNode): BotComment[] {
if (!KNOWN_BOT_LOGINS.has(firstComment.author.login)) continue;

comments.push({
threadId: thread.id,
path: thread.path,
line: thread.line,
startLine: thread.startLine,
Expand Down Expand Up @@ -757,7 +760,7 @@ const SINGLE_PR_QUERY = `query($owner: String!, $name: String!, $number: Int!) {
}}
}}}}
reviewThreads(first: 50) { nodes {
isResolved isOutdated path line startLine
id isResolved isOutdated path line startLine
comments(first: 3) { nodes {
author { login }
body
Expand Down Expand Up @@ -1202,6 +1205,7 @@ function spawnClaude(
});
}


async function fixPr(pr: ScoredPr, config: PatrolConfig): Promise<void> {
log(`${cl.bold}→${cl.reset} Fixing PR ${cl.cyan}#${pr.number}${cl.reset} (${pr.title})`);
log(` Issues: ${cl.yellow}${pr.issues.join(', ')}${cl.reset}`);
Expand Down Expand Up @@ -1254,6 +1258,12 @@ async function fixPr(pr: ScoredPr, config: PatrolConfig): Promise<void> {
},
}).catch(() => log(' Warning: could not post summary comment'));
}

// Note: we intentionally do NOT auto-resolve bot review threads here.
// A zero exit code only means Claude ran without crashing — it does not
// guarantee every open thread was addressed. Blanket resolution would
// dismiss valid feedback that wasn't actually fixed. Threads are resolved
// by CodeRabbit re-review after the fix is pushed, or manually.
} else if (result.hitMaxTurns) {
const failCount = recordMaxTurnsFailure(pr.number);
outcome = 'max-turns';
Expand Down
Loading
Loading