-
Notifications
You must be signed in to change notification settings - Fork 0
fix: replace hourly scheduled deploy with per-push deploy on production #1814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -331,8 +331,35 @@ jobs: | |
|
|
||
| gh issue create --title "$TITLE" --body "$BODY" --label "bug,groundskeeper-autofix" | ||
|
|
||
| # Deploy job removed — production deploys are now handled by the scheduled | ||
| # deploy hook (scheduled-deploy.yml, every hour) instead of per-push. | ||
| # This caps Vercel build minutes at 24/day max vs 50-80/day previously. | ||
| # vercel.json sets github.enabled=false to prevent Vercel from posting | ||
| # PR failure statuses (deploy hooks bypass the GitHub integration). | ||
| deploy: | ||
| # Trigger Vercel production deployment after CI passes on the production branch. | ||
| # Vercel GitHub integration is disabled (vercel.json github.enabled=false) to | ||
| # prevent PR failure statuses — deploy hooks bypass the GitHub integration. | ||
| # The VERCEL_DEPLOY_HOOK_URL secret must be a hook configured for the "production" branch. | ||
| needs: [ci] | ||
| if: github.ref == 'refs/heads/production' && github.event_name == 'push' | ||
coderabbitai[bot] marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
|
|
||
| steps: | ||
| - name: Trigger Vercel production deployment | ||
| run: | | ||
| if [ -z "${{ secrets.VERCEL_DEPLOY_HOOK_URL }}" ]; then | ||
| echo "::error::VERCEL_DEPLOY_HOOK_URL secret is not set." | ||
| echo "Go to Vercel Dashboard → Project → Settings → Git → Deploy Hooks" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we move some of this to TS? This seems error prone |
||
| echo "Create a hook for Branch 'production', then add the URL as a GitHub secret." | ||
| exit 1 | ||
| fi | ||
|
|
||
| RESPONSE=$(curl -s -o /tmp/vercel_response.json -w "%{http_code}" \ | ||
| -X POST "${{ secrets.VERCEL_DEPLOY_HOOK_URL }}") | ||
|
|
||
| echo "HTTP status: $RESPONSE" | ||
| cat /tmp/vercel_response.json | ||
|
|
||
| if [ "$RESPONSE" -ge 200 ] && [ "$RESPONSE" -lt 300 ]; then | ||
| echo "Production deployment triggered." | ||
| else | ||
| echo "::error::Vercel deploy hook returned HTTP $RESPONSE" | ||
| exit 1 | ||
| fi | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.