Test coverage: add tests for ValueError in double_commutator#1264
Open
mhucka wants to merge 2 commits intoquantumlib:mainfrom
Open
Test coverage: add tests for ValueError in double_commutator#1264mhucka wants to merge 2 commits intoquantumlib:mainfrom
ValueError in double_commutator#1264mhucka wants to merge 2 commits intoquantumlib:mainfrom
Conversation
Added test cases to DoubleCommutatorTest in commutators_test.py to cover the cases where the intersection of indices for hopping operators in double_commutator results in an empty set or a set with more than one element, which triggers a ValueError.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces two new unit tests for the double_commutator function in src/openfermion/utils/commutators_test.py. These tests cover edge cases for hopping operators where the index intersections are either empty or contain multiple elements, verifying that the function correctly returns zero. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test cases to
DoubleCommutatorTestincommutators_test.pyto cover the cases where the intersection of indices for hopping operators in double_commutator results in an empty set or a set with more than one element, which triggers aValueError.